exe: build cleanup#31109
Merged
alyssawilk merged 7 commits intoenvoyproxy:mainfrom Dec 5, 2023
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
build_cleanup2
branch
from
588aa2e to
182284a
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
build_cleanup2
branch
from
182284a to
73f70bf
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
alyssawilk
force-pushed
the
build_cleanup2
branch
from
bb146be to
3c05be3
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
build_cleanup2
branch
from
3c05be3 to
27e6c08
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
RyanTheOptimist
approved these changes
Dec 5, 2023
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Yay! Thanks for doing this!
delphisfang
pushed a commit
to delphisfang/envoy
that referenced
this pull request
Dec 10, 2023
This does make the main common lib no longer contain all extensions. Risk Level: low (should be no-op) Testing: existing tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
eric846
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Dec 14, 2023
- change `context.runtime()` to `context.serverFactoryContext().runtime()` in source/server/http_dynamic_delay_filter_config.cc due to envoyproxy/envoy#31189 and implemented PANIC methods in NighthawkServerFactoryContext - replace `@envoy//source/exe:envoy_common_lib_with_external_headers` with `@envoy//source/exe:all_extensions_lib_with_external_headers` due to envoyproxy/envoy#31109 - replace `@envoy//source/exe:main_common_lib_with_external_headers` with `@envoy//source/exe:main_common_with_all_extensions_lib_with_external_headers` due to a combination of envoyproxy/envoy#30924 and envoyproxy/envoy#31109 causing unit test `UtilityAddressResolutionTest, AddressResolution` failed because `envoy.network.dns_resolver.cares` was not linked in - lower `upstream_cx_rx_bytes_total` counter threshold in `test_http_h2` integration test. - disable oghttp2 in Nighthawk which was enabled by default in Envoy in envoyproxy/envoy@b58d312 - sync files Signed-off-by: Qin Qin <qqin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does make the main common lib no longer contain all extensions.
Risk Level: low (should be no-op)
Testing: existing tests
Docs Changes: n/a
Release Notes: n/a