aws: fix usage of reloadable_features.use_http_client_to_fetch_aws_credentials#31135
Merged
mattklein123 merged 4 commits intoenvoyproxy:mainfrom Dec 1, 2023
Merged
Conversation
…aws_credentials Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
Contributor
Author
|
/assign @JuniorHsu |
|
🙀 Error while processing event: |
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
JuniorHsu
approved these changes
Nov 30, 2023
Contributor
JuniorHsu
left a comment
JuniorHsu
left a comment
There was a problem hiding this comment.
thanks for fixing this. just one nit from me!
added 2 commits
November 30, 2023 22:47
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
Contributor
Author
|
/retest |
mattklein123
approved these changes
Dec 1, 2023
jbohanon
added a commit
to solo-io/envoy-gloo
that referenced
this pull request
Mar 6, 2024
soloio-bulldozer Bot
pushed a commit
to solo-io/envoy-gloo
that referenced
this pull request
Mar 12, 2024
* bump envoy-fork, fix extensions * fix FactoryContext from envoyproxy/envoy#31189 * more build fixes * fix MockFactoryContext * use xds pkg for unified matcher instead of udpa * export the build options * another ServerFactoryContext * use typed_config for lambda filter test * runtime flag...? * runtime flag...as a string...? * use nullopt instead of server factory context. why? not sure yet * put the server factory context back and try a different runtime flag per envoyproxy/envoy#31135 * nuke le asan * uhh * use libcurl, patch out virtual call to ServerFactoryContext::clusterManager() * forgot the patch d'oh * ls on the out dirs * undo commenting creds * add a build dir * derp * what the heck, respect my vars bro * WHY AREN'T WE USING THE RIGHT ENV VARS * look at me. i am the captain now. * shhh, it can't see you if you don't move * well this is nasty but we're getting somewhere * alt+f4 * asan * lower jobs oom-killed * try some more goofiness with the optref * ci shenanigans * server factory context as nullopt * ci nonsense * getting closer * cleanup * remove hard-coding override in initialize() * bump to 1.29.2 * bump to merged --------- Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io>
Contributor
|
@suniltheta is there a plan to flip this true or would it make more sense to remove the flag? |
Contributor
Author
|
I will check with @nbaws if we can flip this to true for upcoming release. And remove it in a release following that. |
Contributor
|
I would prefer to keep this default false for one more release. #34138 was a fairly substantial change to async providers, whilst I'm comfortable it has fixed the original reported issues with this PR the fix has not had sufficient burn time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: aws: fix usage of reloadable_features.use_http_client_to_fetch_aws_credentials
Additional Description: This feature flag will be release in v1.29. In v1.30 we will flip this feature flag to be default enabled. Finally in v1.31 release this feature flag will be removed.
Risk Level:
Testing:
Docs Changes: Yes
Release Notes: Yes
Fixes: #31119