aws: fix assertion failure in debug due to timer access outside of main thread#34138
Merged
mattklein123 merged 31 commits intoenvoyproxy:mainfrom May 29, 2024
Merged
aws: fix assertion failure in debug due to timer access outside of main thread#34138mattklein123 merged 31 commits intoenvoyproxy:mainfrom
mattklein123 merged 31 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Contributor
Author
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Contributor
Author
|
A note on this PR - the majority of the change is to implement a handler for onClusterAddOrDelete, and that handler literally calls refresh() once the cluster is ready to handle requests and is never used again. If there is a shorter and/or cleaner way to do this, please let me know. I've used code from dynamic forward proxy to do most of the onClusterAddOrDelete handling. |
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Member
|
@suniltheta for first pass, thanks. /wait |
suniltheta
reviewed
May 20, 2024
Contributor
suniltheta
left a comment
There was a problem hiding this comment.
thanks for making this change. I am still in process of reviewing tests. Though I would leave f/b as I have them.
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Contributor
Author
|
/retest |
suniltheta
approved these changes
May 23, 2024
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
…metadata_async Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Contributor
Author
|
@suniltheta some minor refactoring - there was an initialization issue I found with upstream filter that I've now addressed. |
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
mattklein123
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: aws: fix assertion failure in debug due to timer access outside of main thread
Additional Description:
Patch to ensure async credential providers do not access main thread timers when credentials are requested. This was a larger fix than originally expected, due to substantial test case rewrites, changes to refresh logic and changes to the cluster initialisation sequence.
This patch performs the following:
Risk Level: Low
Testing: Unit
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #33962
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]