Remove assertions for DrainManagerImpl to be run on main thread.#31701
Closed
furlongmt wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
Remove assertions for DrainManagerImpl to be run on main thread.#31701furlongmt wants to merge 1 commit intoenvoyproxy:mainfrom
furlongmt wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
…e callbacks can be run on the worker thread so we must only check that the dispatcher is thread safe
jmarantz
reviewed
Jan 8, 2024
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
this looks good.
WDYT about adding a unit test that fails without this change? It'd have to use real threads.
Contributor
|
superceded by #31711 so that @furlongmt doesn't need to read the book of knowledge about DCO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove assertions for DrainManagerImpl to be run on main thread. These callbacks can be run on the worker thread so we must only check that the dispatcher is thread safe
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]