server: switch the assert to allow child threads.#31711
Merged
yanavlasov merged 1 commit intoenvoyproxy:mainfrom Jan 10, 2024
Merged
server: switch the assert to allow child threads.#31711yanavlasov merged 1 commit intoenvoyproxy:mainfrom
yanavlasov merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
|
LGTM |
yanjunxiang-google
approved these changes
Jan 9, 2024
yanavlasov
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: The new asserts in #31452 don't allow child draining threads. Sadly there are no tests that catch this in OSS. This tweaks the asserts so this can work, and we have verified this with internal tests.
Additional Description:
Risk Level: low
Testing: just CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a