Adding missing @bazel prefixes that dependencies need.#3175
Merged
ggreenway merged 1 commit intoApr 23, 2018
Conversation
I tested envoyproxy#3021 with envoy-filter-example to verify it works for non-default workspace roots, but didn't realize the filter example's envoy binary is built without linkstamping so the testing was worthless. Experimental evidence is that the `deps` field needs `@envoy` but the linker options are fine without it. I don't understand why this would be true so I'm going to put `@envoy` in both places. Signed-off-by: John Millikin <jmillikin@stripe.com>
ggreenway
approved these changes
Apr 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested #3021 with
envoy-filter-example to verify it works for non-default workspace roots,
but didn't realize the filter example's envoy binary is built without
linkstamping so the testing was worthless.
Experimental evidence is that the
depsfield needs@envoybut thelinker options are fine without it. I don't understand why this would be
true so I'm going to put
@envoyin both places.Risk Level: Low
Signed-off-by: John Millikin jmillikin@stripe.com
Testing:
Tested on a local envoy-filter-example clone with
stamped = Trueset.