Skip to content

Adding missing @bazel prefixes that dependencies need. #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggreenway merged 1 commit into from
Apr 23, 2018
Merged

Adding missing @bazel prefixes that dependencies need. #3175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bazel/envoy_build_system.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,22 +63,22 @@ def _envoy_stamped_linkopts():
# MacOS doesn't have an official equivalent to the `.note.gnu.build-id`
# ELF section, so just stuff the raw ID into a new text section.
"@bazel_tools//tools/osx:darwin": [
"-sectcreate __TEXT __build_id", "$(location //bazel:raw_build_id.ldscript)"
"-sectcreate __TEXT __build_id", "$(location @envoy//bazel:raw_build_id.ldscript)"
],

# Note: assumes GNU GCC (or compatible) handling of `--build-id` flag.
"//conditions:default": [
"-Wl,@$(location //bazel:gnu_build_id.ldscript)",
"-Wl,@$(location @envoy//bazel:gnu_build_id.ldscript)",
],
})

def _envoy_stamped_deps():
return select({
"@bazel_tools//tools/osx:darwin": [
"//bazel:raw_build_id.ldscript"
"@envoy//bazel:raw_build_id.ldscript"
],
"//conditions:default": [
"//bazel:gnu_build_id.ldscript",
"@envoy//bazel:gnu_build_id.ldscript",
],
})

Expand Down