Skip to content

test: make parser_integration_test.cc work with newer versions of gtest.#39297

Merged
adisuissa merged 2 commits intoenvoyproxy:mainfrom
paul-r-gall:FixParserTest
May 1, 2025
Merged

test: make parser_integration_test.cc work with newer versions of gtest.#39297
adisuissa merged 2 commits intoenvoyproxy:mainfrom
paul-r-gall:FixParserTest

Conversation

@paul-r-gall
Copy link
Copy Markdown
Contributor

Commit Message: test: make parser_integration_test.cc work with newer versions of gtest
Additional Description: new versions of gtest do not have . match \n in regex matcher.
Risk Level: no risk
Testing: test-only change

Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa adisuissa enabled auto-merge (squash) May 1, 2025 13:23
@adisuissa
Copy link
Copy Markdown
Contributor

Might need #39299 in order to pass coverage.

@adisuissa adisuissa self-assigned this May 1, 2025
Signed-off-by: Paul Ogilby <pgal@google.com>
@adisuissa adisuissa merged commit 0ea2b70 into envoyproxy:main May 1, 2025
24 checks passed
@paul-r-gall paul-r-gall deleted the FixParserTest branch September 17, 2025 18:26
@paul-r-gall paul-r-gall restored the FixParserTest branch September 17, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants