Skip to content

Revert "Switch coverage CI targets to EngFlow (#39269)"#39299

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
krinkinmu:rollback-eng-flow
May 1, 2025
Merged

Revert "Switch coverage CI targets to EngFlow (#39269)"#39299
phlax merged 1 commit intoenvoyproxy:mainfrom
krinkinmu:rollback-eng-flow

Conversation

@krinkinmu
Copy link
Copy Markdown
Contributor

Commit Message:

This reverts commit e0420ee. It unexpectedly resulted in lower coverage numbers - we should rollback while we are investigating what's going on to avoid disruptions.

Additional Description:

Some relevant discussions can be found in #39030 which prompted me to work on this in the first place. And I will use #39248 as a tracking bug for the coverage changes.

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

+cc @phlax

This reverts commit e0420ee.
It unexpectedly resulted in lower coverage numbers - we should rollback
while we are investigating what's going on to avoid disruptions.

Signed-off-by: Mikhail Krinkin <mkrinkin@microsoft.com>
@krinkinmu krinkinmu force-pushed the rollback-eng-flow branch from 2542edb to 8e4adee Compare May 1, 2025 14:01
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @krinkinmu

@phlax phlax merged commit 10c66fa into envoyproxy:main May 1, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants