Extproc new logging bits#41295
Merged
adisuissa merged 51 commits intoenvoyproxy:mainfrom Dec 16, 2025
Merged
Conversation
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
melginaldi
requested review from
mattklein123,
tyxia and
yanavlasov
as code owners
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
…itional test scenario Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
…-bits Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
…-bits Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Contributor
|
@melginaldi Thanks for working on this. One suggestion is to keep the PR as in draft mode while you are getting the CI passing. |
Contributor
Author
Ack. Thanks for the suggestion! I didn't know I could convert it back to draft. Will send for review once the CI passes |
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
…-bits Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
…-bits Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
melginaldi
commented
Oct 3, 2025
melginaldi
commented
Oct 3, 2025
Contributor
|
/assign @stevenzzzz |
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
…-bits Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Contributor
|
LGTM overall modulo a few nit comments and also pending comments from other reviewers |
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
adisuissa
reviewed
Dec 9, 2025
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Overall LGTM.
Left some comments.
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
…ils.h comments Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
tyxia
pushed a commit
that referenced
this pull request
Feb 25, 2026
…#43558) Commit Message: Track fail open behavior and processing effects to request headers as part of ExtAuthzLoggingInfo to match parity with ext_proc filter. Additional Description: This information will be used by ServiceExtensions for debugging/enhanced monitoring. This functionality was added to the ext_proc filter in #41295 and #41691, these bits are to keep parity with the ext_proc filter. last_req_processing_effect will hold the value of the last mutation event the filter completed on the request headers, whether successful or not. Therefore if 5 headers were successfully added but the 6 was invalid and the filter stopped processing any further mutations, the value of last_processing_effect will be InvalidMutationRejected. Risk Level:Low Testing:Tested in unit/integration tests Release Notes: Added new tracking bit last_req_processing_effect and failed_open to ExtAuthzLoggingInfo Filter State to track mutation events and failed_open occurrences. Docs Changes: N/A Platform Specific Features: N/A /assign @tyxia --------- Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…envoyproxy#43558) Commit Message: Track fail open behavior and processing effects to request headers as part of ExtAuthzLoggingInfo to match parity with ext_proc filter. Additional Description: This information will be used by ServiceExtensions for debugging/enhanced monitoring. This functionality was added to the ext_proc filter in envoyproxy#41295 and envoyproxy#41691, these bits are to keep parity with the ext_proc filter. last_req_processing_effect will hold the value of the last mutation event the filter completed on the request headers, whether successful or not. Therefore if 5 headers were successfully added but the 6 was invalid and the filter stopped processing any further mutations, the value of last_processing_effect will be InvalidMutationRejected. Risk Level:Low Testing:Tested in unit/integration tests Release Notes: Added new tracking bit last_req_processing_effect and failed_open to ExtAuthzLoggingInfo Filter State to track mutation events and failed_open occurrences. Docs Changes: N/A Platform Specific Features: N/A /assign @tyxia --------- Signed-off-by: Melissa Ginaldi <mginaldi@google.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
…envoyproxy#43558) Commit Message: Track fail open behavior and processing effects to request headers as part of ExtAuthzLoggingInfo to match parity with ext_proc filter. Additional Description: This information will be used by ServiceExtensions for debugging/enhanced monitoring. This functionality was added to the ext_proc filter in envoyproxy#41295 and envoyproxy#41691, these bits are to keep parity with the ext_proc filter. last_req_processing_effect will hold the value of the last mutation event the filter completed on the request headers, whether successful or not. Therefore if 5 headers were successfully added but the 6 was invalid and the filter stopped processing any further mutations, the value of last_processing_effect will be InvalidMutationRejected. Risk Level:Low Testing:Tested in unit/integration tests Release Notes: Added new tracking bit last_req_processing_effect and failed_open to ExtAuthzLoggingInfo Filter State to track mutation events and failed_open occurrences. Docs Changes: N/A Platform Specific Features: N/A /assign @tyxia --------- Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
Signed-off-by: Melissa Ginaldi <mginaldi@google.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…envoyproxy#43558) Commit Message: Track fail open behavior and processing effects to request headers as part of ExtAuthzLoggingInfo to match parity with ext_proc filter. Additional Description: This information will be used by ServiceExtensions for debugging/enhanced monitoring. This functionality was added to the ext_proc filter in envoyproxy#41295 and envoyproxy#41691, these bits are to keep parity with the ext_proc filter. last_req_processing_effect will hold the value of the last mutation event the filter completed on the request headers, whether successful or not. Therefore if 5 headers were successfully added but the 6 was invalid and the filter stopped processing any further mutations, the value of last_processing_effect will be InvalidMutationRejected. Risk Level:Low Testing:Tested in unit/integration tests Release Notes: Added new tracking bit last_req_processing_effect and failed_open to ExtAuthzLoggingInfo Filter State to track mutation events and failed_open occurrences. Docs Changes: N/A Platform Specific Features: N/A /assign @tyxia --------- Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
…envoyproxy#43558) Commit Message: Track fail open behavior and processing effects to request headers as part of ExtAuthzLoggingInfo to match parity with ext_proc filter. Additional Description: This information will be used by ServiceExtensions for debugging/enhanced monitoring. This functionality was added to the ext_proc filter in envoyproxy#41295 and envoyproxy#41691, these bits are to keep parity with the ext_proc filter. last_req_processing_effect will hold the value of the last mutation event the filter completed on the request headers, whether successful or not. Therefore if 5 headers were successfully added but the 6 was invalid and the filter stopped processing any further mutations, the value of last_processing_effect will be InvalidMutationRejected. Risk Level:Low Testing:Tested in unit/integration tests Release Notes: Added new tracking bit last_req_processing_effect and failed_open to ExtAuthzLoggingInfo Filter State to track mutation events and failed_open occurrences. Docs Changes: N/A Platform Specific Features: N/A /assign @tyxia --------- Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext_proc: Add processing_effect to ExtProcLoggingInfo
Commit Message: Add a bit to track mutations within ext_proc filter state ExtProcLoggingInfo.
Additional Description: This bit will track if a mutation occurred, if continue_and_replace was used or if an immediate response was sent. This addition will help with observability by gaining visibility into what ext_proc mutations occur.
Memory Implication: Since the defined enum has 4 values I chose use
enum class: charto store the values as chars rather than ints. Therefore each enum variable will only be 1 byte of memory.Risk Level: Low
Testing: Added multiple integration tests to ext_proc_integration_test.cc to validate this bit is set correctly in all 4 scenarios: no mutations, content modified, continue and replace and immediate response
Release Notes: Added new logging bit processing_effect to ExtProcLoggingInfo Filter State to track mutation events per GRPC call. Proccessing_event can be either None, ContentModified, ContinueAndReplace or ImmediateResponse. The default is None except processing mode FULL_DUPLEX_STREAMED whose defualt is Content Modified.
Docs Changes: N/A
Platform Specific Features: N/A
/assign @yanjunxiang-google