Extproc logging bits for Fail Open and Server Half Close by melginaldi · Pull Request #41691 · envoyproxy/envoy

melginaldi · 2025-10-24T21:28:10Z

Commit Message: Add bits to the FilterState in ExtProcLoggingInfo for when a stream fails-open or a server half close happens. Fail open we want to know which specific streams failed open, this is a highly requested visibility stat by service extension customers. Server Half close is a counter.
Additional Description: These bits will be useful for internal debugging and filtering metrics. This is build off of #41602
Risk Level: Low
Testing: Unit Integration tests

Docs Changes: N/A
Release Notes: Add new bits into ExtProcLoggingInfo for tracking fail-open occurrences.
Platform Specific Features: N/A

/assign @yanjunxiang-google

…in FilterState Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

repokitteh-read-only · 2025-10-24T21:28:18Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41691 was opened by melginaldi.

see: more, trace.

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…l-open Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

agrawroh · 2025-11-03T22:17:44Z

cc @yanjunxiang-google Could you please do a first pass?

/wait-any

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

melginaldi · 2025-12-08T18:02:07Z

@melginaldi this needs a main merge and conflict resolution

i think its also waiting on your feedback/iteration

/wait

Done - I have merged and resolved open comments

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…l-open Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…ng-fail-open Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

yanjunxiang-google · 2025-12-11T20:20:29Z

LGTM

adisuissa · 2025-12-11T20:54:48Z

hmmm... is this conflicting with #41602 ? Seems that the other PR is contained in this one.

melginaldi · 2025-12-11T20:56:54Z

hmmm... is this conflicting with #41602 ? Seems that the other PR is contained in this one.

Yeah, this branch (extproc_logging_fail_open) is branched off of extproc_logging_immresp_contrep. It's a sub branch of the other so I assume I need to submit the other one first?

adisuissa · 2025-12-12T03:26:06Z

Yeah, this branch (extproc_logging_fail_open) is branched off of extproc_logging_immresp_contrep. It's a sub branch of the other so I assume I need to submit the other one first?

After the other PR was merged, the current files currently have conflicts. Once it's cleaned up and pushed, we can approve it.

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

melginaldi · 2025-12-15T21:46:36Z

Yeah, this branch (extproc_logging_fail_open) is branched off of extproc_logging_immresp_contrep. It's a sub branch of the other so I assume I need to submit the other one first?

After the other PR was merged, the current files currently have conflicts. Once it's cleaned up and pushed, we can approve it.

Ack @adisuissa, done.

adisuissa

Thanks, one high-level question.

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…l-open Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

ravenblackx · 2025-12-22T16:51:13Z

Pinged @adisuissa but rapid response not expected because holiday time of year.

adisuissa

LGTM, thanks!

@tyxia

…#43558) Commit Message: Track fail open behavior and processing effects to request headers as part of ExtAuthzLoggingInfo to match parity with ext_proc filter. Additional Description: This information will be used by ServiceExtensions for debugging/enhanced monitoring. This functionality was added to the ext_proc filter in #41295 and #41691, these bits are to keep parity with the ext_proc filter. last_req_processing_effect will hold the value of the last mutation event the filter completed on the request headers, whether successful or not. Therefore if 5 headers were successfully added but the 6 was invalid and the filter stopped processing any further mutations, the value of last_processing_effect will be InvalidMutationRejected. Risk Level:Low Testing:Tested in unit/integration tests Release Notes: Added new tracking bit last_req_processing_effect and failed_open to ExtAuthzLoggingInfo Filter State to track mutation events and failed_open occurrences. Docs Changes: N/A Platform Specific Features: N/A /assign @tyxia --------- Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

@tyxia

…envoyproxy#43558) Commit Message: Track fail open behavior and processing effects to request headers as part of ExtAuthzLoggingInfo to match parity with ext_proc filter. Additional Description: This information will be used by ServiceExtensions for debugging/enhanced monitoring. This functionality was added to the ext_proc filter in envoyproxy#41295 and envoyproxy#41691, these bits are to keep parity with the ext_proc filter. last_req_processing_effect will hold the value of the last mutation event the filter completed on the request headers, whether successful or not. Therefore if 5 headers were successfully added but the 6 was invalid and the filter stopped processing any further mutations, the value of last_processing_effect will be InvalidMutationRejected. Risk Level:Low Testing:Tested in unit/integration tests Release Notes: Added new tracking bit last_req_processing_effect and failed_open to ExtAuthzLoggingInfo Filter State to track mutation events and failed_open occurrences. Docs Changes: N/A Platform Specific Features: N/A /assign @tyxia --------- Signed-off-by: Melissa Ginaldi <mginaldi@google.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>

@tyxia

…envoyproxy#43558) Commit Message: Track fail open behavior and processing effects to request headers as part of ExtAuthzLoggingInfo to match parity with ext_proc filter. Additional Description: This information will be used by ServiceExtensions for debugging/enhanced monitoring. This functionality was added to the ext_proc filter in envoyproxy#41295 and envoyproxy#41691, these bits are to keep parity with the ext_proc filter. last_req_processing_effect will hold the value of the last mutation event the filter completed on the request headers, whether successful or not. Therefore if 5 headers were successfully added but the 6 was invalid and the filter stopped processing any further mutations, the value of last_processing_effect will be InvalidMutationRejected. Risk Level:Low Testing:Tested in unit/integration tests Release Notes: Added new tracking bit last_req_processing_effect and failed_open to ExtAuthzLoggingInfo Filter State to track mutation events and failed_open occurrences. Docs Changes: N/A Platform Specific Features: N/A /assign @tyxia --------- Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

…y#41691) Signed-off-by: Melissa Ginaldi <mginaldi@google.com> Signed-off-by: Gustavo <grnmeira@gmail.com>

@tyxia

…envoyproxy#43558) Commit Message: Track fail open behavior and processing effects to request headers as part of ExtAuthzLoggingInfo to match parity with ext_proc filter. Additional Description: This information will be used by ServiceExtensions for debugging/enhanced monitoring. This functionality was added to the ext_proc filter in envoyproxy#41295 and envoyproxy#41691, these bits are to keep parity with the ext_proc filter. last_req_processing_effect will hold the value of the last mutation event the filter completed on the request headers, whether successful or not. Therefore if 5 headers were successfully added but the 6 was invalid and the filter stopped processing any further mutations, the value of last_processing_effect will be InvalidMutationRejected. Risk Level:Low Testing:Tested in unit/integration tests Release Notes: Added new tracking bit last_req_processing_effect and failed_open to ExtAuthzLoggingInfo Filter State to track mutation events and failed_open occurrences. Docs Changes: N/A Platform Specific Features: N/A /assign @tyxia --------- Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

@tyxia

…envoyproxy#43558) Commit Message: Track fail open behavior and processing effects to request headers as part of ExtAuthzLoggingInfo to match parity with ext_proc filter. Additional Description: This information will be used by ServiceExtensions for debugging/enhanced monitoring. This functionality was added to the ext_proc filter in envoyproxy#41295 and envoyproxy#41691, these bits are to keep parity with the ext_proc filter. last_req_processing_effect will hold the value of the last mutation event the filter completed on the request headers, whether successful or not. Therefore if 5 headers were successfully added but the 6 was invalid and the filter stopped processing any further mutations, the value of last_processing_effect will be InvalidMutationRejected. Risk Level:Low Testing:Tested in unit/integration tests Release Notes: Added new tracking bit last_req_processing_effect and failed_open to ExtAuthzLoggingInfo Filter State to track mutation events and failed_open occurrences. Docs Changes: N/A Platform Specific Features: N/A /assign @tyxia --------- Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

melginaldi added 12 commits October 16, 2025 16:00

Add bits to log ImmediateResoonse and ContinueAndReplace occurrences …

24f4ffa

…in FilterState Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Refactor data logging and write unit tests

99fe980

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-imm…

88f22ba

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Clang format corrections

771a10f

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Clang format and remove deugging comment

169a016

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-imm…

493ca5e

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-imm…

ac73fc1

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Fix small typos

90801e8

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-imm…

eee4503

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Add bit fields for fail-open and server-half-close

a5cb4a4

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Add integration test for new logging fields

b822725

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Add integration tests for new logging bits

84a6a32

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

repokitteh-read-only Bot assigned yanjunxiang-google Oct 24, 2025

melginaldi changed the title ~~Extproc logging fail open~~ Extproc logging bits for Fail Open and Server Half Close Oct 24, 2025

melginaldi added 2 commits October 24, 2025 22:25

Remove comments

93a113f

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-imm…

4793698

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

melginaldi marked this pull request as ready for review October 27, 2025 14:24

melginaldi requested review from mattklein123, tyxia and yanavlasov as code owners October 27, 2025 14:24

melginaldi mentioned this pull request Oct 27, 2025

Ext-proc: Change the default logging status onGrpcClose() #41383

Closed

melginaldi added 7 commits November 3, 2025 17:21

Create helper function for log testing within ext_proc

6b0269b

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-imm…

616f481

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Clang format fix

662e55b

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-fai…

6051ff7

…l-open Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Fix imports to pass prechecks

2b6b8bc

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Uncomment tests

d69b7c2

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-imm…

d1d97e1

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

melginaldi added 3 commits December 8, 2025 17:04

clang format

95e9a70

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge with branch extproc-logging-immresp-contreplace

0fe4963

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Add test for server half closed counter

076fcca

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

repokitteh-read-only Bot removed the waiting label Dec 8, 2025

melginaldi added 5 commits December 11, 2025 19:50

Update changelogs and ext_proc_filters.rst

d2b24f1

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-imm…

1af5686

…resp-contreplace Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-fai…

8e23861

…l-open Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge branch 'extproc-logging-immresp-contreplace' into extproc-loggi…

5def781

…ng-fail-open Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Add changelogs and update docs

eda842b

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge with upstream/amin

d750122

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

adisuissa reviewed Dec 16, 2025

View reviewed changes

Comment thread source/extensions/filters/http/ext_proc/ext_proc.cc Outdated

Comment thread source/extensions/filters/http/ext_proc/ext_proc.cc Outdated

melginaldi added 3 commits December 16, 2025 15:32

Merge with upstream/main

9b088e7

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Create helper function for logging fail open

75e4107

Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

Merge remote-tracking branch 'upstream/main' into extproc-logging-fai…

0c198de

…l-open Signed-off-by: Melissa Ginaldi <mginaldi@google.com>

adisuissa approved these changes Dec 23, 2025

View reviewed changes

adisuissa merged commit c7118f9 into envoyproxy:main Dec 23, 2025
25 checks passed

melginaldi mentioned this pull request Feb 21, 2026

ext_authz: Track Fail Open & ProcessingEffects in ExtAuthzLoggingInfo #43558

Merged

grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026

ext_proc: logging bits for Fail Open and Server Half Close (envoyprox…

e62769e

…y#41691) Signed-off-by: Melissa Ginaldi <mginaldi@google.com> Signed-off-by: Gustavo <grnmeira@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extproc logging bits for Fail Open and Server Half Close#41691

Extproc logging bits for Fail Open and Server Half Close#41691
adisuissa merged 48 commits intoenvoyproxy:mainfrom
melginaldi:extproc-logging-fail-open

melginaldi commented Oct 24, 2025 •

edited

Loading

Uh oh!

repokitteh-read-only Bot commented Oct 24, 2025

Uh oh!

agrawroh commented Nov 3, 2025

Uh oh!

melginaldi commented Dec 8, 2025

Uh oh!

yanjunxiang-google commented Dec 11, 2025

Uh oh!

adisuissa commented Dec 11, 2025

Uh oh!

melginaldi commented Dec 11, 2025

Uh oh!

adisuissa commented Dec 12, 2025

Uh oh!

melginaldi commented Dec 15, 2025

Uh oh!

adisuissa left a comment

Uh oh!

Uh oh!

Uh oh!

ravenblackx commented Dec 22, 2025

Uh oh!

adisuissa left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

melginaldi commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Oct 24, 2025

Uh oh!

agrawroh commented Nov 3, 2025

Uh oh!

melginaldi commented Dec 8, 2025

Uh oh!

yanjunxiang-google commented Dec 11, 2025

Uh oh!

adisuissa commented Dec 11, 2025

Uh oh!

melginaldi commented Dec 11, 2025

Uh oh!

adisuissa commented Dec 12, 2025

Uh oh!

melginaldi commented Dec 15, 2025

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ravenblackx commented Dec 22, 2025

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

melginaldi commented Oct 24, 2025 •

edited

Loading