Skip to content

deps: migrate zstd to BCR-compatible native Bazel build for bzlmod#42007

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
mmorel-35:zstd
Nov 18, 2025
Merged

deps: migrate zstd to BCR-compatible native Bazel build for bzlmod#42007
phlax merged 1 commit intoenvoyproxy:mainfrom
mmorel-35:zstd

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #42007 was opened by mmorel-35.

see: more, trace.

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Nov 13, 2025
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @agrawroh

🐱

Caused by: #42007 was opened by mmorel-35.

see: more, trace.

@mmorel-35 mmorel-35 force-pushed the zstd branch 3 times, most recently from 718ffb7 to 05e1b86 Compare November 13, 2025 10:03
@phlax
Copy link
Copy Markdown
Member

phlax commented Nov 13, 2025

looks like this needs a fix for the zstd cli bin

Comment thread tools/coverage/BUILD Outdated
@mmorel-35 mmorel-35 force-pushed the zstd branch 2 times, most recently from fa73290 to 7a4f7a9 Compare November 14, 2025 16:10
@mmorel-35 mmorel-35 marked this pull request as ready for review November 14, 2025 17:03
@phlax phlax self-assigned this Nov 15, 2025
@agrawroh agrawroh removed their assignment Nov 15, 2025
Comment thread bazel/foreign_cc/BUILD Outdated
Comment thread bazel/repositories.bzl Outdated
Comment thread contrib/qat/compression/qatzstd/compressor/source/BUILD Outdated
Comment thread tools/zstd/BUILD Outdated
Comment thread tools/coverage/report_generator.sh.template Outdated
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mmorel-35

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 18, 2025
@phlax phlax merged commit 604cd8d into envoyproxy:main Nov 18, 2025
25 checks passed
@mmorel-35 mmorel-35 deleted the zstd branch November 18, 2025 10:31
@phlax phlax mentioned this pull request Nov 24, 2025
grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026
…nvoyproxy#42007)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Gustavo <grnmeira@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants