googleurl: change repo #42185
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
| ], | ||
| deps = [ | ||
| "@com_googlesource_googleurl//url", | ||
| "@com_github_google_gurl//url", |
There was a problem hiding this comment.
what is the bcr name (if any)?
would be great if we can shorten this to just @gurl
There was a problem hiding this comment.
no module registered - https://registry.bazel.build/search?q=googleurl
There was a problem hiding this comment.
It will be googleurl : https://github.com/google/gurl/blob/main/MODULE.bazel
There was a problem hiding this comment.
what is the bcr name (if any)?
What is bcr name?
There was a problem hiding this comment.
bazel is moving to a module/repo system - known as bzlmod
bcr - is the "bazel central registry"
its generally a good idea to follow established patterns with naming - and the move is towards short module names (thankfully)
in this case i think it should be called googleurl rather than com_github_etc
There was a problem hiding this comment.
I'm seeing surrounding deps all following the current naming pattern com_github_foo. I'd defer renaming to after we eventually move to bzlmod.
There was a problem hiding this comment.
for recent renaming prs see
- chore: migrate zlib to use BUILD.bazel from BCR #42159
- chore: Use native BUILD.bazel from gperftools #42105
- deps: migrate zstd to BCR-compatible native Bazel build for bzlmod #42007
these ones were selected more because they were using foreign_cc and there was the opportunity to switch to a ~pure bazel recipe - but we took the opportunity while doing it to move to bzlmod names
i think if you are going to rename it should be to the (expected) bzlmod name
There was a problem hiding this comment.
done with renaming
Signed-off-by: Dan Zhang <danzh@google.com>
|
/retest |
1 similar comment
|
/retest |
repokitteh-read-only
Bot
removed
the
deps
|
/backport |
repokitteh-read-only
Bot
added
the
backport/review
switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl. the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon. Signed-off-by: Dan Zhang <danzh@google.com>
switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl. the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon. Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Faseela K <faseela.k@est.tech>
switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl. the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon. Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Faseela K <faseela.k@est.tech>
switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl. the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon. Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Faseela K <faseela.k@est.tech>
switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl. the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon. Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Faseela K <faseela.k@est.tech>
switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl. the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon. Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Faseela K <faseela.k@est.tech>
switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl. the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon. Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Faseela K <faseela.k@est.tech>
switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl. the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon. Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Faseela K <faseela.k@est.tech>
switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl. the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon. Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Faseela K <faseela.k@est.tech>
switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl. the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon. Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
4 participants
Commit Message: switch to https://github.com/google/gurl from https://quiche.googlesource.com/googleurl.
the old .tar host https://storage.googleapis.com/quiche-envoy-integration/ will be turned down very soon.
Risk Level: low, the new repo is mirrored
Testing: existing tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A