chore: migrate zlib to use BUILD.bazel from BCR#42159
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Nov 22, 2025
Merged
Conversation
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
mmorel-35
force-pushed
the
zlib
branch
2 times, most recently
from
0fe4ad4 to
9cde90b
Compare
mmorel-35
force-pushed
the
zlib
branch
8 times, most recently
from
7bf3189 to
4d6cfea
Compare
mmorel-35
requested review from
KBaichoo,
RyanTheOptimist,
abeyad,
danzh2010,
kyessenov and
mattklein123
as code owners
Member
|
/retest |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Contributor
Author
|
/retest |
phlax
reviewed
Nov 21, 2025
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
really, really cool - thanks so much @mmorel-35
did you have more changes, or shall we land it?
phlax
approved these changes
Nov 21, 2025
repokitteh-read-only
Bot
removed
the
deps
Contributor
Author
|
That's all for me |
mmorel-35
added a commit
to mmorel-35/envoy
that referenced
this pull request
Nov 22, 2025
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Contributor
|
@mmorel-35 @phlax hasn't this broken the ability to compile with |
Member
|
not afaiaa - we test it in the compile_time_options test |
Contributor
|
what I mean is that the flag doesn't do anything or does it? I cannot seem to find somewhere we end up selecting |
Member
|
i see - if you want to raise a ticket i can look at it |
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]