Skip to content

test: Updating integration tests certificate and creation script#44332

Merged
phlax merged 3 commits intoenvoyproxy:mainfrom
adisuissa:upodate_certs_20260408
Apr 8, 2026
Merged

test: Updating integration tests certificate and creation script#44332
phlax merged 3 commits intoenvoyproxy:mainfrom
adisuissa:upodate_certs_20260408

Conversation

@adisuissa
Copy link
Copy Markdown
Contributor

Commit Message: test: Updating integration tests certificate and creation script
Additional Description:
integration tests certificate have expired.
This PR updates them by invoking './certs.sh'.
Updated the creation script to create old certificates.

Risk Level: low - tests only
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@adisuissa adisuissa marked this pull request as ready for review April 8, 2026 18:00
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #44332 was opened by adisuissa.

see: more, trace.

@jukie
Copy link
Copy Markdown
Contributor

jukie commented Apr 8, 2026

CI might fail from not including the dynamic-module fixes as well, see #44330

@yanavlasov
Copy link
Copy Markdown
Contributor

Is #44330 a dupe of this PR?

@jukie
Copy link
Copy Markdown
Contributor

jukie commented Apr 8, 2026

Yes, I opened #44330 prior to yours. Feel free to move forward with this one instead. Looks like mine has some CI issues still.

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@adisuissa
Copy link
Copy Markdown
Contributor Author

Somewhat unfortunate to have 2 breakages at the same time, and that a PR needs to address both (sometimes we cherry pick some PRs and those that do multiple changes require special handling).
I don't mind that #44330 will be merged, and I'll discard this PR.

@adisuissa
Copy link
Copy Markdown
Contributor Author

adisuissa commented Apr 8, 2026

oh, I think #44330 doesn't include the expired_cert

@jukie
Copy link
Copy Markdown
Contributor

jukie commented Apr 8, 2026

I originally started that PR with only the expired certs fix and then if I'm not mistaken CI was failing because it didn't also include the dynamic module fixes so I cherry-picked those changes.

Edit: now I see what you mean, I was missing one.

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@phlax
Copy link
Copy Markdown
Member

phlax commented Apr 8, 2026

pushing through - lets land the rust fix immediately after

@phlax phlax merged commit 6151149 into envoyproxy:main Apr 8, 2026
26 of 28 checks passed
nezdolik pushed a commit to nezdolik/envoy that referenced this pull request Apr 10, 2026
…oyproxy#44332)

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
nezdolik pushed a commit to nezdolik/envoy that referenced this pull request Apr 10, 2026
…oyproxy#44332)

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
nezdolik pushed a commit to nezdolik/envoy that referenced this pull request Apr 10, 2026
…oyproxy#44332)

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
nezdolik pushed a commit to nezdolik/envoy that referenced this pull request Apr 10, 2026
…oyproxy#44332)

Signed-off-by: Adi Suissa-Peleg <adip@google.com>

Signed-off-by: Adi (Suissa) Peleg <adip@google.com>
phlax pushed a commit that referenced this pull request Apr 10, 2026
)

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
nshipilov pushed a commit to nshipilov/envoy that referenced this pull request Apr 13, 2026
…oyproxy#44332)

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
krinkinmu pushed a commit to grnmeira/envoy that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants