Fix problems with bazel query#5821
Conversation
htuch
left a comment
There was a problem hiding this comment.
This seems legit, although strictly not needed for normal use, since api/ is only ever seen as a local repository remount. I assume the vscode plugin isn't smart enough to grok that api/ shouldn't be treated as part of the outer repo.
BTW you also need to reflect the build rename for the gRPC example in https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/grpc_bridge
|
Thanks for the super fast feedback! :) |
|
Please merge master to pick up #5827. |
Renamed examples/grpc-bridge/script/build to avoid problems on OS X with case insensitive filesystems Signed-off-by: Robert Panzer <robert.panzer.pb@googlemail.com>
Signed-off-by: Robert Panzer <robert.panzer.pb@googlemail.com>
26dadb0 to
79cfbcd
Compare
|
Thanks! I rebased and force pushed. However I got this error from the recommit checks: I don't know if this only happens when pushing from OSX or if I have a wrong version of clang-format. |
|
@robertpanzer re: your local error, sometimes you get this if you clang-format is a different version to the one used in CI, so that might be a place to look. I don't personally use the precommit hooks. |
|
@robertpanzer can you merge master? |
lizan
left a comment
There was a problem hiding this comment.
This break data-plane-api to build independently with bazel, should we just put a set of directories to .bazelignore and that might just solve your problem?
|
Closing this out in favor of #5886 which just merged |
|
@htuch Sorry I wasn't able to catch up as I was traveling over the weekend. |
|
@robertpanzer @mergeconflict also uses vscode and was the author of #5886. Maybe you can sync on Slack to discuss the workflow? |
|
I created #5909 to track the problem that this PR tried to solve. |
Description:
At the moment it is impossible for me to import the Envoy repository into VS Code using the "official" Bazel plugin.
This is because it calls
bazel querywhich fails on problems with the BUILD files in the api folder:This PR fixes this by changing the load path.
Additionally I renamed the file
examples/grpc-bridge/script/buildtoexamples/grpc-bridge/script/build.shasbazel queryidentifies this as a Bazel build file on OS X due to the case insensitive file system.Risk Level:
If the build passes it should be fine.
Testing:
Test that the API still works.
Docs Changes:
None
Release Notes:
None
[Optional Fixes #Issue]
[Optional Deprecated:]