Skip to content

fix bazel query#5886

Merged
htuch merged 2 commits into
envoyproxy:masterfrom
mergeconflict:fix_bazel_query
Feb 10, 2019
Merged

fix bazel query#5886
htuch merged 2 commits into
envoyproxy:masterfrom
mergeconflict:fix_bazel_query

Conversation

@mergeconflict
Copy link
Copy Markdown

Description: fix bazel query
Risk Level: Low
Testing: built //source/exe:envoy-static
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Dan Rosen mergeconflict@google.com

Dan Rosen added 2 commits February 8, 2019 16:43
Signed-off-by: Dan Rosen <mergeconflict@google.com>
Signed-off-by: Dan Rosen <mergeconflict@google.com>
@mergeconflict
Copy link
Copy Markdown
Author

To be honest, I don't actually know if this is correct, or if the @//api/... trick in #5821 is better, or neither. Specifically, I don't know if this change will break anybody using the standalone https://github.com/envoyproxy/data-plane-api.

@lizan
Copy link
Copy Markdown
Member

lizan commented Feb 9, 2019

This should be better than #5821.

/retest

@repokitteh-read-only
Copy link
Copy Markdown

🔨 rebuilding ci/circleci: ipv6_tests (failed build)

🐱

Caused by: a #5886 (comment) was created by @lizan.

see: more, trace.

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@htuch htuch merged commit d841d20 into envoyproxy:master Feb 10, 2019
@mergeconflict mergeconflict deleted the fix_bazel_query branch February 10, 2019 23:20
fredlas pushed a commit to fredlas/envoy that referenced this pull request Mar 5, 2019
fix bazel query

Risk Level: Low
Testing: built //source/exe:envoy-static

Signed-off-by: Dan Rosen <mergeconflict@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants