fix bazel query more#5904
Merged
mattklein123 merged 1 commit intoFeb 11, 2019
Merged
Conversation
Signed-off-by: Dan Rosen <mergeconflict@google.com>
Author
htuch
approved these changes
Feb 11, 2019
Member
|
@mergeconflict clang-tidy run use query pretty heavy, so probably change https://github.com/envoyproxy/envoy/blob/master/tools/gen_compilation_database.py#L82 to |
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Dan Rosen <mergeconflict@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fix a BUILD file that was missed in #5886.
Risk Level: Low
Testing: reran
bazel query ...Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Dan Rosen mergeconflict@google.com