Update rules_foreign_cc version by hlopko · Pull Request #7058 · envoyproxy/envoy

hlopko · 2019-05-23T08:57:35Z

It contains forward fixes for Bazel 0.27.0

Description:
Risk Level: Low
Testing: Presubmits

hlopko · 2019-05-23T10:35:54Z

It seems Bazel < 0.25.2 is used. Are there plans to bump the version to 0.25.2? @htuch

htuch · 2019-05-23T23:05:34Z

CC @lizan

lizan · 2019-05-24T08:32:38Z

Yeah it needs #6866, which I couldn't make coverage works

hlopko · 2019-05-28T07:15:59Z

I can make rules_foreign_cc work with 0.24 to unblock myself (I will update this PR once bazel-contrib/rules_foreign_cc#270 is submitted).

But we will need to speed up other incompatible flags migrations (we - the Bazel team - are in increased pressure because 0.27 will start a 3 month window of no incompatible changes). We will have to potentially temporarily disable envoy on our downstream pipeline.

hlopko · 2019-05-28T09:45:16Z

Hi @lizan @htuch

I've updated this PR and it should be green. Failures on the ci look unrelated (java.io.IOException: Error downloading [https://github.com/google/benchmark/archive/v1.5.tar.gz]).

Can we move forward with this PR?

moderation · 2019-05-28T14:46:53Z

@hlopko It looks like there is a new release of v1.5.0 of benchmark so they have updated the binary. This makes our sha check fail. To fix this we'll need a PR to correct the sha. I can create this if you like.

hlopko · 2019-05-28T14:58:40Z

That'd be great, thanks!

htuch · 2019-05-28T14:58:50Z

@moderation see #7090

hlopko · 2019-05-28T16:42:25Z

/retest

repokitteh-read-only · 2019-05-28T16:42:33Z

🔨 rebuilding ci/circleci: clang_tidy (failed build)
🔨 rebuilding ci/circleci: asan (failed build)
🔨 rebuilding ci/circleci: tsan (failed build)
🔨 rebuilding ci/circleci: ipv6_tests (failed build)
🔨 rebuilding ci/circleci: release (failed build)
🔨 rebuilding ci/circleci: compile_time_options (failed build)

🐱

Caused by: a #7058 (comment) was created by @hlopko.

see: more, trace.

htuch · 2019-05-28T17:30:15Z

@hlopko please merge master to pick up the fix in #7090

Last run of the CI (https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/124) shows only Tensorflow and Envoy issues. Envoy is fixed by envoyproxy/envoy#7058, and Tensorflow is fixed in Bazel@HEAD by cab65ff. RELNOTES: Incompatible flag `--incompatible_require_ctx_in_configure_features` has been flipped. See #7793 for more information. PiperOrigin-RevId: 250458681

hlopko · 2019-05-29T10:43:09Z

udp_listener_impl_test failure in envoy-macos seems unrelated (maybe flake?).
ci/circleci:coverage prints
//test/coverage:coverage_tests TIMEOUT in 4015.0s

which also seems unrelated?

hlopko · 2019-05-29T10:43:49Z

Oh and to be explicit - I rebased this PR on master, fixes for #7090 are in now.

htuch · 2019-05-30T21:27:08Z

/retest

repokitteh-read-only · 2019-05-30T21:27:13Z

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #7058 (comment) was created by @htuch.

see: more, trace.

htuch · 2019-05-30T21:27:19Z

/azp run

azure-pipelines · 2019-05-30T21:27:37Z

Azure Pipelines successfully started running 2 pipeline(s).

htuch · 2019-05-30T21:31:40Z

@hlopko coverage seems to be broken in rules_foreign_cc in the most recent run at https://circleci.com/gh/envoyproxy/envoy/226403?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

lizan · 2019-06-03T20:42:52Z

@hlopko Can you merge master to pickup #6866 contains the fix for coverage?

Update rules_foreign_cc to bazel-contrib/rules_foreign_cc@604f1e1 Signed-off-by: Marcel Hlopko <hlopko@google.com>

Signed-off-by: Marcel Hlopko <hlopko@google.com>

hlopko · 2019-06-04T09:10:24Z

I just did that. Does #6866 actually fix coverage? https://circleci.com/gh/envoyproxy/envoy/226720?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link seems like a failing build.

In any case, it seems this PR still fails with coverage:

git clone '--shallow-since=1551386336 +0000' https://go.googlesource.com/tools /build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/external/org_golang_x_tools
error: unknown option `shallow-since=1551386336 +0000'

lizan · 2019-06-04T16:44:22Z

/retest
@hlopko yes it does, the failing CI for this PR seems a transient error with network.

repokitteh-read-only · 2019-06-04T16:44:27Z

🔨 rebuilding ci/circleci: api (failed build)
🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #7058 (comment) was created by @lizan.

see: more, trace.

lizan · 2019-06-04T16:46:32Z

@hlopko also do not rebase + force-push in the future, it mess up GH review history and hard to track last master merge. A regular merge is preferred. The PR will be squashed into one commit at the end anyway.

lizan · 2019-06-04T23:41:31Z

Closing in favor of #7168

Last run of the CI (https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/124) shows only Tensorflow and Envoy issues. Envoy is fixed by envoyproxy/envoy#7058, and Tensorflow is fixed in Bazel@HEAD by bazelbuild@cab65ff. RELNOTES: Incompatible flag `--incompatible_require_ctx_in_configure_features` has been flipped. See bazelbuild#7793 for more information. PiperOrigin-RevId: 250458681

Last run of the CI (https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/124) shows only Tensorflow and Envoy issues. Envoy is fixed by envoyproxy/envoy#7058, and Tensorflow is fixed in Bazel@HEAD by bazelbuild/bazel@cab65ff. RELNOTES: Incompatible flag `--incompatible_require_ctx_in_configure_features` has been flipped. See bazelbuild/bazel#7793 for more information. PiperOrigin-RevId: 250458681

hlopko force-pushed the update_rules_foreign_cc branch from d98c5cc to 4568df8 Compare May 23, 2019 08:58

mattklein123 assigned lizan May 23, 2019

hlopko mentioned this pull request May 28, 2019

Bazel incompatible changes #6995

Closed

hlopko force-pushed the update_rules_foreign_cc branch 3 times, most recently from 0816b1e to cec30d8 Compare May 28, 2019 08:38

hlopko force-pushed the update_rules_foreign_cc branch from 34a2d23 to d01ba3b Compare May 29, 2019 07:54

hlopko added 2 commits June 4, 2019 11:04

Update rules_foreign_cc version

10e1d18

Update rules_foreign_cc to bazel-contrib/rules_foreign_cc@604f1e1 Signed-off-by: Marcel Hlopko <hlopko@google.com>

Update rules_foreign_cc to bazel-contrib/rules_foreign_cc@6b2f454

8190124

Signed-off-by: Marcel Hlopko <hlopko@google.com>

hlopko force-pushed the update_rules_foreign_cc branch from d01ba3b to 8190124 Compare June 4, 2019 09:04

lizan mentioned this pull request Jun 4, 2019

Update dependency on rules_foreign_cc #7168

Merged

lizan closed this Jun 4, 2019

Conversation

hlopko commented May 23, 2019

Uh oh!

hlopko commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

htuch commented May 23, 2019

Uh oh!

lizan commented May 24, 2019

Uh oh!

hlopko commented May 28, 2019

Uh oh!

hlopko commented May 28, 2019

Uh oh!

moderation commented May 28, 2019

Uh oh!

hlopko commented May 28, 2019

Uh oh!

htuch commented May 28, 2019

Uh oh!

hlopko commented May 28, 2019

Uh oh!

repokitteh-read-only Bot commented May 28, 2019

Uh oh!

htuch commented May 28, 2019

Uh oh!

hlopko commented May 29, 2019

Uh oh!

hlopko commented May 29, 2019

Uh oh!

htuch commented May 30, 2019

Uh oh!

repokitteh-read-only Bot commented May 30, 2019

Uh oh!

htuch commented May 30, 2019

Uh oh!

azure-pipelines Bot commented May 30, 2019

Uh oh!

htuch commented May 30, 2019

Uh oh!

lizan commented Jun 3, 2019

Uh oh!

hlopko commented Jun 4, 2019

Uh oh!

lizan commented Jun 4, 2019

Uh oh!

repokitteh-read-only Bot commented Jun 4, 2019

Uh oh!

lizan commented Jun 4, 2019

Uh oh!

lizan commented Jun 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hlopko commented May 23, 2019 •

edited

Loading