Skip to content

Update dependency on rules_foreign_cc#7168

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
laurentlb:master
Jun 4, 2019
Merged

Update dependency on rules_foreign_cc#7168
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
laurentlb:master

Conversation

@laurentlb
Copy link
Copy Markdown
Contributor

@laurentlb laurentlb commented Jun 4, 2019

With this update, Envoy is compatible with the upcoming Bazel 0.27.

#6995

Risk Level: low
Testing: bazel-0.27.0rc2-linux-x86_64 build ... --nobuild
Docs Changes: no
Release Notes: no

With this update, Envoy is compatible with the upcoming Bazel 0.27.

Signed-off-by: Laurent Le Brun <laurentlb@gmail.com>
@laurentlb
Copy link
Copy Markdown
Contributor Author

cc @keith, @htuch

@lizan
Copy link
Copy Markdown
Member

lizan commented Jun 4, 2019

@laurentlb Does this supersede #7058?

@lizan lizan self-assigned this Jun 4, 2019
@laurentlb
Copy link
Copy Markdown
Contributor Author

I didn't see the other PR, but yes it supersedes it (cc @hlopko).
It's just one commit difference (based on the history: https://github.com/bazelbuild/rules_foreign_cc/commits/master), but that commit is important.

@lizan
Copy link
Copy Markdown
Member

lizan commented Jun 4, 2019

@laurentlb OK once CI passes I will merge this one and close the other.

@mattklein123 mattklein123 merged commit e0c9284 into envoyproxy:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants