ci: fix gcovr dependency path.#769
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Apr 17, 2017
Merged
Conversation
After envoyproxy#747, we no longer have the BUILD_DISTINCT=1 set of dependencies in the CI image, so fix the gcovr path to solve the failures in envoyproxy#760. Also fixed a snafu in configs/configgen.sh that I hit when running Docker as non-root. It was trying to peek at the user's home directory, with no passwd entry.
Member
mattklein123
approved these changes
Apr 17, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Virtual Clusters allow Envoy Mobile to emit stats based on matching criteria. This allows users to single out important traffic for their application. This PR adds an API to the client builder to add virtual cluster configuration and emission of virtual cluster stats. Note: the client builder API exposed here is not ideal #770 tracks enhancing this. Risk Level: low Testing: unit tests, and local stats test. #769 tracks adding CI tests for stats Docs Changes: added docs for the new API. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Virtual Clusters allow Envoy Mobile to emit stats based on matching criteria. This allows users to single out important traffic for their application. This PR adds an API to the client builder to add virtual cluster configuration and emission of virtual cluster stats. Note: the client builder API exposed here is not ideal #770 tracks enhancing this. Risk Level: low Testing: unit tests, and local stats test. #769 tracks adding CI tests for stats Docs Changes: added docs for the new API. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #747, we no longer have the BUILD_DISTINCT=1 set of dependencies in the CI image, so fix the
gcovr path to solve the failures in #760.
Also fixed a snafu in configs/configgen.sh that I hit when running Docker as non-root. It was trying
to peek at the user's home directory, with no passwd entry.