build: update build image to 98a1276049a3cf4bebc6a0343217444a8675baf8#760
Closed
mattklein123 wants to merge 1 commit intomasterfrom
Closed
build: update build image to 98a1276049a3cf4bebc6a0343217444a8675baf8#760mattklein123 wants to merge 1 commit intomasterfrom
mattklein123 wants to merge 1 commit intomasterfrom
Conversation
Member
Author
Member
|
LGTM, let me know if there are any issues. |
Member
Author
|
@htuch looks like coverage is failing: https://travis-ci.org/lyft/envoy/jobs/221897553 |
Member
|
Will look into this early tomorrow if that's OK. |
Member
Author
|
Yup no problem. |
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 14, 2017
After envoyproxy#747, we no longer have the BUILD_DISTINCT=1 set of dependencies in the CI image, so fix the gcovr path to solve the failures in envoyproxy#760.
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 14, 2017
After envoyproxy#747, we no longer have the BUILD_DISTINCT=1 set of dependencies in the CI image, so fix the gcovr path to solve the failures in envoyproxy#760. Also fixed a snafu in configs/configgen.sh that I hit when running Docker as non-root. It was trying to peek at the user's home directory, with no passwd entry.
Member
Author
|
Closing in favor of #769 |
mattklein123
pushed a commit
that referenced
this pull request
Apr 17, 2017
After #747, we no longer have the BUILD_DISTINCT=1 set of dependencies in the CI image, so fix the gcovr path to solve the failures in #760. Also fixed a snafu in configs/configgen.sh that I hit when running Docker as non-root. It was trying to peek at the user's home directory, with no passwd entry.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: in preparation of cutting v0.3 I went ahead and audited inline TODOs. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: in preparation of cutting v0.3 I went ahead and audited inline TODOs. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
dmehala
pushed a commit
to DataDog/envoy
that referenced
this pull request
May 12, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976)
wdauchy
pushed a commit
to wdauchy/envoy
that referenced
this pull request
Nov 13, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version
wdauchy
pushed a commit
to wdauchy/envoy
that referenced
this pull request
Dec 8, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version envoy-build: Update our image to ubuntu 24 Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This adds the `retest` action to workflow, we use that in eg repo, this is quite useful for contributors to run /retest in PR if action failed (for flaky issues) --------- Signed-off-by: bitliu <bitliu@tencent.com>
henrymwang
pushed a commit
to DataDog/envoy
that referenced
this pull request
Apr 13, 2026
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version envoy-build: Update our image to ubuntu 24 Signed-off-by: William Dauchy <william.dauchy@datadoghq.com> build Signed-off-by: William Dauchy <william.dauchy@datadoghq.com> build Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.