fixed misspelling of use_original_dst#976
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom May 16, 2017
Merged
Conversation
RomanDzhabarov
approved these changes
May 16, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: after #873, we needed dropped iOS 10.0 support Risk: low - iOS 10.0 was released in 2016, and thus can be phased out. Testing: CI Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: after #873, we needed dropped iOS 10.0 support Risk: low - iOS 10.0 was released in 2016, and thus can be phased out. Testing: CI Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
dmehala
pushed a commit
to DataDog/envoy
that referenced
this pull request
May 12, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976)
wdauchy
pushed a commit
to wdauchy/envoy
that referenced
this pull request
Nov 13, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version
wdauchy
pushed a commit
to wdauchy/envoy
that referenced
this pull request
Dec 8, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version envoy-build: Update our image to ubuntu 24 Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Previously, we assumed that Envoy Gateway was deployed in the standard mode where Gateway pods, deployments and daemonsets are all deployed and managed in the Envoy Gateway namespace. However, there's an emerging new feature of Envoy Gateway, called "GatewayNamespace" [1], where these resources are created locally in the same namespace as Gateway object. This change generalizes Gateway controller's logic so that AIGW works regardless of the Envoy Gateway deployment model. As a result, we no longer need `--envoyGatewayNamespace` flag. [1]: https://gateway.envoyproxy.io/docs/tasks/operations/gateway-namespace-mode/ **Related Issues/PRs (if applicable)** Closes #976 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
henrymwang
pushed a commit
to DataDog/envoy
that referenced
this pull request
Apr 13, 2026
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version envoy-build: Update our image to ubuntu 24 Signed-off-by: William Dauchy <william.dauchy@datadoghq.com> build Signed-off-by: William Dauchy <william.dauchy@datadoghq.com> build Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correcting this as it just tripped me up...