Skip to content

http: allow body data to be added be filters during trailers callbacks#959

Merged
mattklein123 merged 3 commits intomasterfrom
trailers_data
May 15, 2017
Merged

http: allow body data to be added be filters during trailers callbacks#959
mattklein123 merged 3 commits intomasterfrom
trailers_data

Conversation

@mattklein123
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 commented May 14, 2017

This is needed for GRPC <-> JSON transcoding. See comments in filter.h
for more details. This commit also includes a partial cleanup and hardening
of the connection manager tests.

Note that this is a breaking change for filters that were previously using
the writable buffered data callbacks. They have been replace with a more
robust method.

Fixes #925

@mattklein123
http: allow body data to be added be filters during trailers callbacks
94e7125 
This is needed for GRPC <-> JSON transcoding. See comments in filter.h
for more details. This commit also includes a partial cleanup and hardening
of the connection manager tests.

Note that this is a breaking change for filters that were previously using
the writable buffered data callbacks. They have been replace with a more
robust method.

Fixes #925
@mattklein123
Copy link
Copy Markdown
Member Author

mattklein123 commented May 14, 2017

@fengli79 @lizan this should fix both of your issues. It's a large change, but the new API is much more robust and will allow for the filter manager to have better error checking of filter code in the future (not present in this change).

cc @lyft/network-team

@mattklein123 mattklein123 mentioned this pull request May 14, 2017
Merged
lizan
lizan reviewed May 15, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will try with transcoding filter in istio later.

fengli79
fengli79 reviewed May 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@fengli79 fengli79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mattklein123 mattklein123 merged commit 8f9d56f into master May 15, 2017
@mattklein123 mattklein123 deleted the trailers_data branch May 15, 2017 18:15
lizan added a commit to lizan/proxy that referenced this pull request May 15, 2017
@lizan
Support streaming response
5ffc386 
- Comply with envoyproxy/envoy#959
@lizan lizan mentioned this pull request May 15, 2017
Merged
lizan added a commit to istio/proxy that referenced this pull request May 15, 2017
@lizan
Support streaming response (#313)
36f4e29 
- Comply with envoyproxy/envoy#959
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
@istio-testing
Update_Dependencies (envoyproxy#959)
bed28a7 
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of proxy

This PR will be merged automatically once checks are successful.
```release-note
none
```
jpsim pushed a commit that referenced this pull request Nov 28, 2022
@rebello95 @jpsim
ci: fix docs publishing job (#959)
cf4cd7e 
Reverts some of the changes from envoyproxy/envoy-mobile@859c38d in order to fix our docs publishing job. After some investigating, it appears that setting the default branch for a GitHub pages site to a non-`master` branch (like `main`) does not properly load, and results in 404s.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
@rebello95 @jpsim
ci: fix docs publishing job (#959)
ba190f1 
Reverts some of the changes from envoyproxy/envoy-mobile@859c38d in order to fix our docs publishing job. After some investigating, it appears that setting the default branch for a GitHub pages site to a non-`master` branch (like `main`) does not properly load, and results in 404s.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>
dmehala pushed a commit to DataDog/envoy that referenced this pull request May 12, 2025
@wdauchy
Add ci to envoy-private
85d7213 
* [Datadog CI] fix missing --load docker option

* ci: Update service account for gitlab ci runners (envoyproxy#760)

This should fix the error we're seeing now

```
ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information
```

example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523

Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image`
jobs as this repo should have its own CI runners

fix CI (envoyproxy#959)

[FCP-1208] Add fips compliance labels (envoyproxy#962)

envoy-private: build fips image on top of fips base image (envoyproxy#964)

campaigner for envoy-private (envoyproxy#960)

Upgrade ddsign client version

ci: add check on format and pre-commit (envoyproxy#976)
wdauchy pushed a commit to wdauchy/envoy that referenced this pull request Nov 13, 2025
@wdauchy
Add ci to envoy-private
048bfde 
* [Datadog CI] fix missing --load docker option

* ci: Update service account for gitlab ci runners (envoyproxy#760)

This should fix the error we're seeing now

```
ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information
```

example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523

Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image`
jobs as this repo should have its own CI runners

fix CI (envoyproxy#959)

[FCP-1208] Add fips compliance labels (envoyproxy#962)

envoy-private: build fips image on top of fips base image (envoyproxy#964)

campaigner for envoy-private (envoyproxy#960)

Upgrade ddsign client version

ci: add check on format and pre-commit (envoyproxy#976)

ci: fix protobuf generation from laptop (envoyproxy#985)

chore: fix CI

Changes:
  - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`.
  - Update ci image used by Gitlab.
  - Enforce clang configuration for building envoy

Upgrade ddsign client version
wdauchy pushed a commit to wdauchy/envoy that referenced this pull request Dec 8, 2025
@wdauchy
Add ci to envoy-private
21e654f 
* [Datadog CI] fix missing --load docker option

* ci: Update service account for gitlab ci runners (envoyproxy#760)

This should fix the error we're seeing now

```
ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information
```

example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523

Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image`
jobs as this repo should have its own CI runners

fix CI (envoyproxy#959)

[FCP-1208] Add fips compliance labels (envoyproxy#962)

envoy-private: build fips image on top of fips base image (envoyproxy#964)

campaigner for envoy-private (envoyproxy#960)

Upgrade ddsign client version

ci: add check on format and pre-commit (envoyproxy#976)

ci: fix protobuf generation from laptop (envoyproxy#985)

chore: fix CI

Changes:
  - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`.
  - Update ci image used by Gitlab.
  - Enforce clang configuration for building envoy

Upgrade ddsign client version

envoy-build: Update our image to ubuntu 24

Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
mathetake added a commit that referenced this pull request Mar 3, 2026
@mathetake
extproc: ignore nanoseconds part of created timestamp (#962)
1a0d92f 
**Description**

Previously, "created" field in the chat completion responses etc assumes
that its value is a json number without floating point part, meaning it
must be parsable as int64 at Go level. Since OpenAI clearly states that
it is an integer json number in the API documentation, it is natural
logic we have. However, Sambanova returns the created field in the
1234.56789 format where it includes "nanoseconds" in the floating point
part which results in the parsing error at the extproc. This fixes it by
ignoring the nanoseconds part since we are not using it on the response
path anyways.


**Related Issues/PRs (if applicable)**

Closes #959

---------

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
henrymwang pushed a commit to DataDog/envoy that referenced this pull request Apr 13, 2026
@wdauchy
Add ci to envoy-private
a93938e 
* [Datadog CI] fix missing --load docker option

* ci: Update service account for gitlab ci runners (envoyproxy#760)

This should fix the error we're seeing now

```
ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information
```

example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523

Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image`
jobs as this repo should have its own CI runners

fix CI (envoyproxy#959)

[FCP-1208] Add fips compliance labels (envoyproxy#962)

envoy-private: build fips image on top of fips base image (envoyproxy#964)

campaigner for envoy-private (envoyproxy#960)

Upgrade ddsign client version

ci: add check on format and pre-commit (envoyproxy#976)

ci: fix protobuf generation from laptop (envoyproxy#985)

chore: fix CI

Changes:
  - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`.
  - Update ci image used by Gitlab.
  - Enforce clang configuration for building envoy

Upgrade ddsign client version

envoy-build: Update our image to ubuntu 24

Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>

build

Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>

build

Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@lizan lizan lizan left review comments

@fengli79 fengli79 fengli79 left review comments

@ccaraman ccaraman ccaraman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattklein123 @lizan @ccaraman @fengli79