tracing: document zipkin headers that services need to propagate#962
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom May 15, 2017
Merged
tracing: document zipkin headers that services need to propagate#962mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Member
|
Other text on this page still makes it sound like Lightstep is the only supported tracer. Do you mind fixing? |
| providers. Currently the only supported provider is for `LightStep <http://lightstep.com/>`_. | ||
| However other providers for systems such as `Zipkin <http://zipkin.io/>`_ or `OpenTracing | ||
| <http://opentracing.io/>`_ would not be difficult to add. | ||
| providers. Currently the Envoy supports `LightStep <http://lightstep.com/>`_ and `Zipkin <http://zipkin.io/>`_. |
Member
|
+1 |
mattklein123
approved these changes
May 15, 2017
htuch
pushed a commit
that referenced
this pull request
May 23, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Add initial support for HTTP body data chunks to be bridged to platform filter invocations. Risk Level: Moderate Testing: Local Signed-off-by: Mike Schore mike.schore@gmail.com Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Add initial support for HTTP body data chunks to be bridged to platform filter invocations. Risk Level: Moderate Testing: Local Signed-off-by: Mike Schore mike.schore@gmail.com Signed-off-by: JP Simard <jp@jpsim.com>
dmehala
pushed a commit
to DataDog/envoy
that referenced
this pull request
May 12, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976)
wdauchy
pushed a commit
to wdauchy/envoy
that referenced
this pull request
Nov 13, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version
wdauchy
pushed a commit
to wdauchy/envoy
that referenced
this pull request
Dec 8, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version envoy-build: Update our image to ubuntu 24 Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Previously, "created" field in the chat completion responses etc assumes that its value is a json number without floating point part, meaning it must be parsable as int64 at Go level. Since OpenAI clearly states that it is an integer json number in the API documentation, it is natural logic we have. However, Sambanova returns the created field in the 1234.56789 format where it includes "nanoseconds" in the floating point part which results in the parsing error at the extproc. This fixes it by ignoring the nanoseconds part since we are not using it on the response path anyways. **Related Issues/PRs (if applicable)** Closes #959 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
henrymwang
pushed a commit
to DataDog/envoy
that referenced
this pull request
Apr 13, 2026
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version envoy-build: Update our image to ubuntu 24 Signed-off-by: William Dauchy <william.dauchy@datadoghq.com> build Signed-off-by: William Dauchy <william.dauchy@datadoghq.com> build Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.