test: fix FakeStream::encodeData to copy data before posting#985
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom May 18, 2017
Merged
test: fix FakeStream::encodeData to copy data before posting#985htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
htuch
approved these changes
May 18, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Updates the stream client builder to accept a closure returning a `Filter` rather than requiring `Filter` to have an `init()` in its protocol conformance. This allows consumers to provide more flexible implementations of "factories" (closures) that can be used with custom initializers or alongside additional logic. Note: Generics are required here since `Filter.name` is needed. As part of this change, I also fixed some outdated documentation of this function. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Updates the stream client builder to accept a closure returning a `Filter` rather than requiring `Filter` to have an `init()` in its protocol conformance. This allows consumers to provide more flexible implementations of "factories" (closures) that can be used with custom initializers or alongside additional logic. Note: Generics are required here since `Filter.name` is needed. As part of this change, I also fixed some outdated documentation of this function. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
wdauchy
pushed a commit
to wdauchy/envoy
that referenced
this pull request
Nov 13, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version
wdauchy
pushed a commit
to wdauchy/envoy
that referenced
this pull request
Dec 8, 2025
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version envoy-build: Update our image to ubuntu 24 Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Previously, we had "filterapi/x" package to enable advanced users to build their own extproc with some custom metrics handling. In practice, the only use case was to "add some headers as a labels of metrics". Now that #981 is in, that can be achieved without rebuilding extproc by themselves by utilizing the new flag. Therefore, this removes the package altogether to eliminate the unnecessary code. **Related Issues/PRs (if applicable)** Follow up on #981 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
henrymwang
pushed a commit
to DataDog/envoy
that referenced
this pull request
Apr 13, 2026
* [Datadog CI] fix missing --load docker option * ci: Update service account for gitlab ci runners (envoyproxy#760) This should fix the error we're seeing now ``` ERROR: Job failed (system failure): prepare environment: setting up build pod: pods "runner-xzxvyd9d-project-3351-concurrent-1" is forbidden: error looking up service account gitlab-runner-envoy/envoy-private: serviceaccount "envoy-private" not found. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information ``` example job: https://gitlab.ddbuild.io/DataDog/envoy-private/-/jobs/423302523 Also adds the `specific:true` tag to the `deliver-ci` and `envoy-image` jobs as this repo should have its own CI runners fix CI (envoyproxy#959) [FCP-1208] Add fips compliance labels (envoyproxy#962) envoy-private: build fips image on top of fips base image (envoyproxy#964) campaigner for envoy-private (envoyproxy#960) Upgrade ddsign client version ci: add check on format and pre-commit (envoyproxy#976) ci: fix protobuf generation from laptop (envoyproxy#985) chore: fix CI Changes: - Update base docker image on `f4a881a1205e8e6db1a57162faf3df7aed88eae8`. - Update ci image used by Gitlab. - Enforce clang configuration for building envoy Upgrade ddsign client version envoy-build: Update our image to ubuntu 24 Signed-off-by: William Dauchy <william.dauchy@datadoghq.com> build Signed-off-by: William Dauchy <william.dauchy@datadoghq.com> build Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.