Skip to content

ci: add clang head/5.0 to CI image#873

Merged
mattklein123 merged 3 commits intomasterfrom
add_clang_5
May 2, 2017
Merged

ci: add clang head/5.0 to CI image#873
mattklein123 merged 3 commits intomasterfrom
add_clang_5

Conversation

@mattklein123
Copy link
Copy Markdown
Member

No description provided.

@mattklein123
Copy link
Copy Markdown
Member Author

@htuch

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to pin to a specific version, so we don't magically pick up a new one on each rebuild without explicit bumping?

@mattklein123
Copy link
Copy Markdown
Member Author

Let me try to see what they have in the repo.

@mattklein123
Copy link
Copy Markdown
Member Author

mklein@localhost:~/Source/envoy-private/envoy/ci/build_container$ apt-cache madison clang-4.0
 clang-4.0 | 1:4.0~svn301550-1~exp1 | http://apt.llvm.org/xenial llvm-toolchain-xenial-4.0/main amd64 Packages

@htuch ^

I don't think multiple versions are available, so I think we are stuck. What do you want to do? Optimally I would agree it would be pinned, but not sure how to do that unless we run our own PPA somewhere.

@htuch
Copy link
Copy Markdown
Member

htuch commented May 2, 2017

OK, let's go with this for now, and be prepared to suspect compiler drift when the ASAN/MSAN/TSAN runs break.

@mattklein123 mattklein123 merged commit 8e5885a into master May 2, 2017
@mattklein123 mattklein123 deleted the add_clang_5 branch May 2, 2017 15:33
@htuch
Copy link
Copy Markdown
Member

htuch commented May 2, 2017

@mattklein123 please let me know when you have a Docker image ID for me to consume, I'll add the Travis build targets for TSAN/MSAN/ASAN.

jpsim pushed a commit that referenced this pull request Nov 28, 2022
Description: after #873, we needed dropped iOS 10.0 support
Risk: low - iOS 10.0 was released in 2016, and thus can be phased out.
Testing: CI

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Description: after #873, we needed dropped iOS 10.0 support
Risk: low - iOS 10.0 was released in 2016, and thus can be phased out.
Testing: CI

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants