docs: misc doc debt#8678
Merged
mattklein123 merged 3 commits intomasterfrom Oct 21, 2019
Merged
Conversation
htuch
reviewed
Oct 21, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Nice improvements! A couple of questions..
| of the :ref:`HttpConnectionManager | ||
| <envoy_api_msg_config.filter.network.http_connection_manager.v2.HttpConnectionManager>` config. | ||
|
|
||
| .. http:post:: /envoy.api.v2.ScopedRoutesDiscoveryService/StreamScopedRoutes |
Member
There was a problem hiding this comment.
Do we want to switch to using protodoc for service documentation? These seem more like pseudo-REST than gRPC..
Member
Author
There was a problem hiding this comment.
This is tracked in #3091. I agree this should all be auto generated, but I was just trying to get us to parity for now.
Signed-off-by: Matt Klein <mklein@lyft.com>
alyssawilk
reviewed
Oct 21, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Awesome, thank you so much for tackling these!
Member
Author
|
@htuch @alyssawilk updated |
alyssawilk
approved these changes
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8190
Fixes #7420
Fixes #7331
Fixes #7312
Fixes #7284