Skip to content

build: patch protobuf to deal with too long CLI issues.#9824

Merged
htuch merged 1 commit into
envoyproxy:masterfrom
htuch:fix-cli-too-long
Jan 24, 2020
Merged

build: patch protobuf to deal with too long CLI issues.#9824
htuch merged 1 commit into
envoyproxy:masterfrom
htuch:fix-cli-too-long

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Jan 24, 2020

Since #9383 merged, I've been unable to bazel build @envoy_api//...

Upstream fix at protocolbuffers/protobuf#7135

Adding as a patch to avoid having to bump protobuf version when that
merges just for this.

Risk level: Low
Testing: bazel build @envoy_api//...

Signed-off-by: Harvey Tuch htuch@google.com

Since envoyproxy#9383 merged, I've been unable to bazel build @envoy_api//...

Upsteam fix at protocolbuffers/protobuf#7135

Adding as a patch to avoid having to bump protobuf version when that
merges just for this.

Risk level: Low
Testing: bazel build @envoy_api//...

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch requested a review from lizan January 24, 2020 19:07
@htuch htuch assigned lizan and asraa Jan 24, 2020
Copy link
Copy Markdown
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@htuch htuch merged commit df99c2a into envoyproxy:master Jan 24, 2020
@htuch htuch deleted the fix-cli-too-long branch January 24, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants