Fix CLI "too long" issues in py_proto_library.#7135
Closed
htuch wants to merge 2 commits into
Closed
Conversation
Envoy was experiencing failed builds due to lots of duplicate -I in the CLI. The solution is to generally use depset() as per Starlark best practice for this sort of thing. Might fix other issues beyond py_proto_library, anything that depends on proto_gen. release notes: no Signed-off-by: Harvey Tuch <htuch@google.com>
Contributor
Author
|
Can someone explain what is going wrong with the release notes here and mergeable? It's a pretty horrible experience as a contributor. |
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Jan 24, 2020
Since envoyproxy#9383 merged, I've been unable to bazel build @envoy_api//... Upsteam fix at protocolbuffers/protobuf#7135 Adding as a patch to avoid having to bump protobuf version when that merges just for this. Risk level: Low Testing: bazel build @envoy_api//... Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
to envoyproxy/envoy
that referenced
this pull request
Jan 24, 2020
Since #9383 merged, I've been unable to bazel build @envoy_api//... Upstream fix at protocolbuffers/protobuf#7135 Adding as a patch to avoid having to bump protobuf version when that merges just for this. Risk level: Low Testing: bazel build @envoy_api//... Signed-off-by: Harvey Tuch <htuch@google.com>
Contributor
Author
|
Friendly ping. |
Contributor
Author
|
Closing, will try again in #7458 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Envoy was experiencing failed builds due to lots of duplicate -I in the
CLI. The solution is to generally use depset() as per Starlark best
practice for this sort of thing.
Might fix other issues beyond py_proto_library, anything that depends on
proto_gen.
release notes: no
Signed-off-by: Harvey Tuch htuch@google.com