fix Envoy Gateway Fails to Add xDS Listener#273
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Aug 29, 2022
Merged
Conversation
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
==========================================
- Coverage 58.45% 58.13% -0.33%
==========================================
Files 31 31
Lines 2773 2778 +5
==========================================
- Hits 1621 1615 -6
- Misses 1058 1067 +9
- Partials 94 96 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lizan
approved these changes
Aug 29, 2022
| // Use only router. | ||
| HttpFilters: []*hcm.HttpFilter{{ | ||
| Name: wellknown.Router, | ||
| Name: wellknown.Router, |
Member
There was a problem hiding this comment.
in fact name can be omit because it isn't needed
Member
Author
There was a problem hiding this comment.
yes, prefer to keep it for better reading
arkodg
reviewed
Aug 29, 2022
| HttpFilters: []*hcm.HttpFilter{{ | ||
| Name: wellknown.Router, | ||
| Name: wellknown.Router, | ||
| ConfigType: &hcm.HttpFilter_TypedConfig{TypedConfig: routerAny}, |
Contributor
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #267
Signed-off-by: hejianpeng hejianpeng2@huawei.com
cc @danehans