fix Envoy Fails to Add Router

[zirain]

fixes: #272
Signed-off-by: hejianpeng hejianpeng2@huawei.com

wait #273

[danehans]

@zirain I am still seeing the same #272 issue with this PR:

Envoy Gateway Logs

2022-08-29T16:43:11.320Z	INFO	cache/logrwrapper.go:24	nodeID "envoy-eg-6f568884ff-6f4gx" requested type.googleapis.com/envoy.config.listener.v3.Listener[] and known map[]. Diff []	{"runner": "xds-server"}
2022-08-29T16:43:11.320Z	INFO	cache/logrwrapper.go:24	respond type.googleapis.com/envoy.config.listener.v3.Listener[] version "" with version "1"	{"runner": "xds-server"}
2022-08-29T16:43:11.320Z	INFO	cache/logrwrapper.go:24	Sending Response on stream 3 to node envoy-eg-6f568884ff-6f4gx	{"runner": "xds-server"}

Envoy Logs

[2022-08-29 16:43:10.292][1][warning][config] [source/common/config/grpc_subscription_impl.cc:126] gRPC config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) listener_default-eg-http_8080: Didn't find a registered implementation for 'envoy.filters.http.router' with type URL: ''

The failed CI run supports these findings.

[danehans]

Remove whitespace.

[arkodg]

afaik this shouldnt be needed here, the Gateway API translator should have set this to * while creating the IR

gateway/internal/ir/xds.go

Line 84 in a4773ec

if len(h.Hostnames) == 0 {

[arkodg]

looks like Validate is not called today, will raise a PR once #216 is in to call Validate before performing a Store

[arkodg]

raised #276

[danehans]

FYI @zirain @arkodg I do not see this issue when I create an HTTPRoute that includes a hostname. FOr example:

apiVersion: gateway.networking.k8s.io/v1alpha2
kind: HTTPRoute
metadata:
  name: httpbin
spec:
  parentRefs:
  - name: eg
  hostnames:
  - "*.example.com"
  rules:
  - backendRefs:
    - name: httpbin
      port: 80

[zirain]

@danehans I face this issue with the yaml files your provider here

I'm OK to close this PR, which is a kind of defensive programming.

[zirain]

replaced by #286