Skip to content

validate ir before sending it#276

Merged
danehans merged 1 commit intoenvoyproxy:mainfrom
arkodg:validate-ir
Aug 30, 2022
Merged

validate ir before sending it#276
danehans merged 1 commit intoenvoyproxy:mainfrom
arkodg:validate-ir

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented Aug 29, 2022

  • Validate the xds and infra IR in the gatewayapi runner
    before sending it to the next stage consuming the IRs

  • refactor infra ir validate

Signed-off-by: Arko Dasgupta arko@tetrate.io

* Validate the xds and infra IR in the gatewayapi runner
before sending it to the next stage consuming the IRs

* refactor infra ir validate

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner August 29, 2022 18:19
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #276 (7726e5b) into main (d3c041f) will decrease coverage by 0.25%.
The diff coverage is 68.96%.

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   58.45%   58.20%   -0.26%     
==========================================
  Files          31       31              
  Lines        2773     2785      +12     
==========================================
  Hits         1621     1621              
- Misses       1058     1067       +9     
- Partials       94       97       +3     
Impacted Files Coverage Δ
internal/gatewayapi/translator.go 85.43% <0.00%> (-0.62%) ⬇️
internal/infrastructure/kubernetes/infra.go 58.33% <ø> (+3.43%) ⬆️
internal/xds/translator/listener.go 47.19% <50.00%> (-0.43%) ⬇️
internal/ir/infra.go 71.23% <81.81%> (ø)
internal/infrastructure/kubernetes/deployment.go 82.16% <100.00%> (+0.70%) ⬆️
internal/provider/kubernetes/gateway.go 77.04% <0.00%> (-6.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danehans danehans merged commit a958828 into envoyproxy:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants