Skip to content

infra: support reloadable EnvoyGateway configuration#4299

Closed
zirain wants to merge 13 commits into
envoyproxy:mainfrom
zirain:reload-cfg
Closed

infra: support reloadable EnvoyGateway configuration#4299
zirain wants to merge 13 commits into
envoyproxy:mainfrom
zirain:reload-cfg

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Sep 22, 2024

fixes: #3209

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 11.01695% with 210 lines in your changes missing coverage. Please review.

Project coverage is 65.53%. Comparing base (958df48) to head (b5f5749).

Files with missing lines Patch % Lines
...nternal/envoygateway/config/loader/configloader.go 0.00% 54 Missing ⚠️
internal/infrastructure/runner/runner.go 0.00% 42 Missing ⚠️
internal/cmd/server.go 0.00% 26 Missing ⚠️
internal/provider/runner/runner.go 0.00% 18 Missing ⚠️
internal/gatewayapi/runner/runner.go 12.50% 14 Missing ⚠️
internal/globalratelimit/runner/runner.go 33.33% 14 Missing ⚠️
internal/xds/server/runner/runner.go 33.33% 14 Missing ⚠️
internal/extension/registry/extension_manager.go 0.00% 13 Missing ⚠️
internal/xds/translator/runner/runner.go 20.00% 11 Missing and 1 partial ⚠️
internal/provider/kubernetes/kubernetes.go 77.77% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4299      +/-   ##
==========================================
- Coverage   65.80%   65.53%   -0.27%     
==========================================
  Files         200      201       +1     
  Lines       24277    24396     +119     
==========================================
+ Hits        15976    15989      +13     
- Misses       7159     7268     +109     
+ Partials     1142     1139       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread internal/envoygateway/config/runner/runner.go Outdated
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Sep 23, 2024

failed because ExtensionAPISettings didn't updated. It's able to add new watcher after EnvoyGateway updated, but cannot remove watcher after EnvoyGateway updated.

zirain added 2 commits October 5, 2024 18:15
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain marked this pull request as ready for review October 5, 2024 11:52
@zirain zirain requested a review from a team as a code owner October 5, 2024 11:52
@zirain zirain requested a review from shawnh2 October 8, 2024 11:18
Comment thread internal/common/runner.go Outdated
Comment thread internal/envoygateway/config/loader/Loader.go Outdated
Comment thread internal/envoygateway/config/loader/Loader.go Outdated
Comment thread internal/envoygateway/config/loader/Loader.go Outdated
Comment thread internal/gatewayapi/runner/runner.go
Comment thread internal/gatewayapi/runner/runner.go Outdated
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from arkodg October 10, 2024 02:42
Comment thread internal/provider/kubernetes/kubernetes.go
Comment thread internal/infrastructure/kubernetes/ratelimit_infra.go Outdated
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Comment thread internal/xds/server/runner/runner.go Outdated
Signed-off-by: zirain <zirain2009@gmail.com>
@zhaohuabing
Copy link
Copy Markdown
Member

Dealing with configuration reload for each runner can be cumbersome, especially as the EnvoyGateway may introduce additional settings in the future. Would it be more straightforward to restart all runners instead of reloading the configuration individually?

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 16, 2024

close this first in favor of #4451, maybe came back later.

@zirain zirain closed this Oct 16, 2024
@zirain zirain deleted the reload-cfg branch January 12, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enhancement: apply EnvoyGateway without manually restarting the EG deployment

4 participants