support reloadable EnvoyGateway configuration#4451
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4451 +/- ##
==========================================
+ Coverage 65.60% 65.83% +0.23%
==========================================
Files 200 203 +3
Lines 30362 30696 +334
==========================================
+ Hits 19919 20210 +291
- Misses 9294 9334 +40
- Partials 1149 1152 +3 ☔ View full report in Codecov by Sentry. |
|
wait #4459 |
e9fdacf to
7248774
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
|
|
||
| # Timeout for deployment to exist (in seconds) | ||
| exist_timeout=25 | ||
| exist_timeout=300 |
There was a problem hiding this comment.
configmap updates to the pod take at least 30 seconds to effect in pod, increase timeout for this.
| kubectl rollout restart deployment envoy-gateway -n envoy-gateway-system | ||
| kubectl rollout status --watch --timeout=5m -n envoy-gateway-system deployment/envoy-gateway | ||
| kubectl wait --timeout=5m -n envoy-gateway-system deployment/envoy-gateway --for=condition=Available |
There was a problem hiding this comment.
EG controller support reload configuration, rollout is unnecessary.
there's no more manual test, our e2e change the |
Ah nice ! Let's remember to delete all the rollout commands in the docs in a follow PR which we suggest when editing EnvoyGateway config |
will update doc after this merged. |
fixes: #3209