Skip to content

support reloadable EnvoyGateway configuration#4451

Merged
zirain merged 5 commits into
envoyproxy:mainfrom
zirain:restart
Oct 18, 2024
Merged

support reloadable EnvoyGateway configuration#4451
zirain merged 5 commits into
envoyproxy:mainfrom
zirain:restart

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Oct 16, 2024

fixes: #3209

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 82.31884% with 61 lines in your changes missing coverage. Please review.

Project coverage is 65.83%. Comparing base (a351c4b) to head (ae74a2e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/envoygateway/config/loader/configloader.go 70.14% 15 Missing and 5 partials ⚠️
internal/filewatcher/worker.go 88.00% 17 Missing and 1 partial ⚠️
internal/cmd/server.go 0.00% 17 Missing ⚠️
internal/infrastructure/runner/runner.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4451      +/-   ##
==========================================
+ Coverage   65.60%   65.83%   +0.23%     
==========================================
  Files         200      203       +3     
  Lines       30362    30696     +334     
==========================================
+ Hits        19919    20210     +291     
- Misses       9294     9334      +40     
- Partials     1149     1152       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 16, 2024

wait #4459

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain marked this pull request as ready for review October 17, 2024 06:50
@zirain zirain requested a review from a team as a code owner October 17, 2024 06:50

# Timeout for deployment to exist (in seconds)
exist_timeout=25
exist_timeout=300
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configmap updates to the pod take at least 30 seconds to effect in pod, increase timeout for this.

Comment thread tools/make/kube.mk
Comment on lines -141 to -143
kubectl rollout restart deployment envoy-gateway -n envoy-gateway-system
kubectl rollout status --watch --timeout=5m -n envoy-gateway-system deployment/envoy-gateway
kubectl wait --timeout=5m -n envoy-gateway-system deployment/envoy-gateway --for=condition=Available
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EG controller support reload configuration, rollout is unnecessary.

Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !
would be great if you can also attach some manual testing logs to the PR

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 18, 2024

LGTM thanks ! would be great if you can also attach some manual testing logs to the PR

there's no more manual test, our e2e change the envoy-gateway-config during set up.
wasm http server changes catched by another e2e test, which spend me a lot of time to find out.

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Oct 18, 2024

LGTM thanks ! would be great if you can also attach some manual testing logs to the PR

there's no more manual test, our e2e change the envoy-gateway-config during set up. wasm http server changes catched by another e2e test, which spend me a lot of time to find out.

Ah nice !

Let's remember to delete all the rollout commands in the docs in a follow PR which we suggest when editing EnvoyGateway config

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Oct 18, 2024

LGTM thanks ! would be great if you can also attach some manual testing logs to the PR

there's no more manual test, our e2e change the envoy-gateway-config during set up. wasm http server changes catched by another e2e test, which spend me a lot of time to find out.

Ah nice !

Let's remember to delete all the rollout commands in the docs in a follow PR which we suggest when editing EnvoyGateway config

will update doc after this merged.

Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@zirain zirain merged commit 5a1c065 into envoyproxy:main Oct 18, 2024
@zirain zirain deleted the restart branch October 18, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enhancement: apply EnvoyGateway without manually restarting the EG deployment

3 participants