chore: move ratelimit per-route config to typedPerFilterConfig#5072
Merged
arkodg merged 3 commits intoenvoyproxy:mainfrom Feb 20, 2025
Merged
chore: move ratelimit per-route config to typedPerFilterConfig#5072arkodg merged 3 commits intoenvoyproxy:mainfrom
arkodg merged 3 commits intoenvoyproxy:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
==========================================
- Coverage 64.97% 64.94% -0.04%
==========================================
Files 214 214
Lines 33532 33511 -21
==========================================
- Hits 21789 21764 -25
- Misses 10400 10405 +5
+ Partials 1343 1342 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
ratelimit-per-route-config
branch
from
8a57226 to
ea1a950
Compare
zhaohuabing
commented
Jan 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Reopen this PR for v1.4. @mathetake @arkodg |
arkodg
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the comment on #5035 (comment)
Release Notes: No