Skip to content

chore: revert ratelimit per-rout config#5749

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:revert-5072
Apr 17, 2025
Merged

chore: revert ratelimit per-rout config#5749
arkodg merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:revert-5072

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

Revert #5072

Some existing users may choose to keep using an old version of envoy while upgrading to new version of Envoy Gateway. To maintain compatibility, we're reverting this change so that rate limit configuration continues to work with older Envoy versions.

We can revisit this in a few versions, once we're confident that older Envoy versions are no longer in use.

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.21%. Comparing base (096cb8d) to head (858f0d5).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/ratelimit.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5749      +/-   ##
==========================================
+ Coverage   65.19%   65.21%   +0.01%     
==========================================
  Files         214      214              
  Lines       34321    34450     +129     
==========================================
+ Hits        22377    22467      +90     
- Misses      10591    10623      +32     
- Partials     1353     1360       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zhaohuabing

@arkodg arkodg requested review from a team April 17, 2025 17:36
@arkodg arkodg merged commit 652b6b4 into envoyproxy:main Apr 17, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants