Skip to content

api: cross-namespace policy target selectors#5145

Open
guydc wants to merge 4 commits intoenvoyproxy:mainfrom
guydc:cross-ns-attachment
Open

api: cross-namespace policy target selectors#5145
guydc wants to merge 4 commits intoenvoyproxy:mainfrom
guydc:cross-ns-attachment

Conversation

@guydc
Copy link
Copy Markdown
Contributor

@guydc guydc commented Jan 24, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Relates to #5143

Release Notes: Yes/No

@guydc guydc requested a review from a team as a code owner January 24, 2025 20:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.84%. Comparing base (d50be42) to head (ba7b099).
⚠️ Report is 1608 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5145      +/-   ##
==========================================
- Coverage   66.88%   66.84%   -0.05%     
==========================================
  Files         210      210              
  Lines       32998    32998              
==========================================
- Hits        22070    22056      -14     
- Misses       9589     9599      +10     
- Partials     1339     1343       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@guydc guydc force-pushed the cross-ns-attachment branch from 5772ec8 to 22e5938 Compare January 24, 2025 21:52
guydc added 3 commits February 2, 2025 11:16
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
@zirain zirain force-pushed the cross-ns-attachment branch from 4d2205a to e672802 Compare February 2, 2025 03:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 7, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added stale and removed stale labels Mar 7, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added stale and removed stale labels Apr 6, 2025

const (
// FromNamespacesAll indicates that the target selector should apply to targets from all namespaces
FromNamespacesAll FromNamespaces = "All"
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have an enum member Same defined here?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added stale and removed stale labels May 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 7, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants