api: cross-namespace policy target selectors#5145
api: cross-namespace policy target selectors#5145guydc wants to merge 4 commits intoenvoyproxy:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5145 +/- ##
==========================================
- Coverage 66.88% 66.84% -0.05%
==========================================
Files 210 210
Lines 32998 32998
==========================================
- Hits 22070 22056 -14
- Misses 9589 9599 +10
- Partials 1339 1343 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5772ec8 to
22e5938
Compare
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
4d2205a to
e672802
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
|
||
| const ( | ||
| // FromNamespacesAll indicates that the target selector should apply to targets from all namespaces | ||
| FromNamespacesAll FromNamespaces = "All" |
There was a problem hiding this comment.
Should we have an enum member Same defined here?
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Relates to #5143
Release Notes: Yes/No