Conversation
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8676 +/- ##
==========================================
+ Coverage 74.40% 74.49% +0.08%
==========================================
Files 245 245
Lines 38973 39275 +302
==========================================
+ Hits 28998 29258 +260
- Misses 7971 8002 +31
- Partials 2004 2015 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
479741a to
7d277a7
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e507c223d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| func resolveExtServerPolicyGatewayTargetRef(policy *unstructured.Unstructured, target policyTargetReferenceWithSectionName, gateways map[types.NamespacedName]*policyGatewayTargetContext) *GatewayContext { | ||
| // Check if the gateway exists | ||
| key := types.NamespacedName{ | ||
| Name: string(target.Name), |
There was a problem hiding this comment.
Resolve gateway targets using the target namespace
extractTargetRefs now returns cross-namespace matches when a ReferenceGrant allows them, but this resolver still keys lookups by policy.GetNamespace(). In that scenario, valid cross-namespace targets are treated as missing, and if a same-named Gateway exists in the policy namespace the policy can bind to the wrong Gateway. The lookup should use target.Namespace from the resolved target reference.
Useful? React with 👍 / 👎.
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
82c7813 to
044fc0c
Compare
Picking up #5145 and continuing the work from here. Thanks, @guydc, for the earlier work on this.