Skip to content

fix: httproute status.parents is not cleaned up#5679

Closed
Xunzhuo wants to merge 1 commit into
envoyproxy:mainfrom
Xunzhuo:fix-status-clean
Closed

fix: httproute status.parents is not cleaned up#5679
Xunzhuo wants to merge 1 commit into
envoyproxy:mainfrom
Xunzhuo:fix-status-clean

Conversation

@Xunzhuo
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo commented Apr 7, 2025

What type of PR is this?

What this PR does / why we need it:

The fix ensures that the status.parents field accurately reflects the current state of the spec.parentRefs field.

Which issue(s) this PR fixes:

Fixes #5656

Release Notes: Yes/No

@Xunzhuo Xunzhuo requested a review from a team as a code owner April 7, 2025 06:05
@Xunzhuo Xunzhuo marked this pull request as draft April 7, 2025 08:03
@Xunzhuo Xunzhuo force-pushed the fix-status-clean branch 2 times, most recently from 193cbb2 to cbdb036 Compare April 7, 2025 09:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (e374db4) to head (a310cd0).
Report is 317 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/status.go 82.85% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5679      +/-   ##
==========================================
- Coverage   65.20%   65.20%   -0.01%     
==========================================
  Files         213      213              
  Lines       34108    34140      +32     
==========================================
+ Hits        22241    22261      +20     
- Misses      10521    10530       +9     
- Partials     1346     1349       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: bitliu <bitliu@tencent.com>
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented May 8, 2025

cc @zhaohuabing didn't you solve a similar problem recently where we only clean up entries related to this contollerName and not other ones ?

@zhaohuabing
Copy link
Copy Markdown
Member

cc @zhaohuabing didn't you solve a similar problem recently where we only clean up entries related to this contollerName and not other ones ?

You mean the PRs that I raised to clean up the HTTPRoute status? Those PRs only handled the conditions, not the parents.

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented May 8, 2025

cc @zhaohuabing didn't you solve a similar problem recently where we only clean up entries related to this contollerName and not other ones ?

You mean the PRs that I raised to clean up the HTTPRoute status? Those PRs only handled the conditions, not the parents.

can you point to that PR so we can reuse the logic here for parents too ?

@zhaohuabing
Copy link
Copy Markdown
Member

zhaohuabing commented May 8, 2025

cc @zhaohuabing didn't you solve a similar problem recently where we only clean up entries related to this contollerName and not other ones ?

You mean the PRs that I raised to clean up the HTTPRoute status? Those PRs only handled the conditions, not the parents.

can you point to that PR so we can reuse the logic here for parents too ?

chore: improve HTTPRoute status errors
chore: improve xRoute status errors

I think nothing there that we can reuse for this PR.

@arkodg arkodg modified the milestones: v1.4.0, Backlog May 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added stale and removed stale labels Jun 12, 2025
@Xunzhuo
Copy link
Copy Markdown
Member Author

Xunzhuo commented Jun 20, 2025

Would love to close this PR for now, hope someone can pick it up, bandwidh will be focused on LLM part.

@Xunzhuo Xunzhuo closed this Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

httproute status.parents is not cleaned up when httproute no longer references gateway in spec.parentRefs (breaks external-dns)

3 participants