fix: httproute status.parents is not cleaned up#5679
Conversation
193cbb2 to
cbdb036
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5679 +/- ##
==========================================
- Coverage 65.20% 65.20% -0.01%
==========================================
Files 213 213
Lines 34108 34140 +32
==========================================
+ Hits 22241 22261 +20
- Misses 10521 10530 +9
- Partials 1346 1349 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: bitliu <bitliu@tencent.com>
d8bb324 to
a310cd0
Compare
|
cc @zhaohuabing didn't you solve a similar problem recently where we only clean up entries related to this contollerName and not other ones ? |
You mean the PRs that I raised to clean up the HTTPRoute status? Those PRs only handled the conditions, not the parents. |
can you point to that PR so we can reuse the logic here for parents too ? |
chore: improve HTTPRoute status errors I think nothing there that we can reuse for this PR. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
Would love to close this PR for now, hope someone can pick it up, bandwidh will be focused on LLM part. |
What type of PR is this?
What this PR does / why we need it:
The fix ensures that the status.parents field accurately reflects the current state of the spec.parentRefs field.
Which issue(s) this PR fixes:
Fixes #5656
Release Notes: Yes/No