chore: improve xRoute status errors#5803
Conversation
00a8c64 to
003d7db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5803 +/- ##
==========================================
- Coverage 65.32% 65.25% -0.07%
==========================================
Files 222 222
Lines 35459 35418 -41
==========================================
- Hits 23164 23113 -51
- Misses 10859 10867 +8
- Partials 1436 1438 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
003d7db to
81e41c1
Compare
There was a problem hiding this comment.
There is an inconsistency between the current Accepted status behavior of TCPRoute and HTTPRoute when the envoyproxy tls setting is invalid. To align with the HTTPRoute, the Accepted status for TCPRoute should be set to True here.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
The condition for multiple rules should be Accepted instead of ResolvedRefs.
There was a problem hiding this comment.
The condition for multiple rules should be Accepted instead of ResolvedRefs.
There was a problem hiding this comment.
The Appcepted status should be True when failed to Resolve the BackendRef for a MirrorFiliter.
There was a problem hiding this comment.
what about the case when backend has no endpoints, do we end up here ?
There was a problem hiding this comment.
Yes, the pervious behavior for backend without endpoints is 500 direct response, and no error status for Accepted and Resolved conditions. This PR doesn't change it.
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
#5747 improves the route status for HTTPRoute. This PR does the same for other(GRPC/TLS/TCP/UDP) Routes.