Skip to content

chore: improve xRoute status errors #5803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhaohuabing merged 3 commits into from
Apr 30, 2025
Merged

chore: improve xRoute status errors #5803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f63f6a
improve route status
zhaohuabing Apr 24, 2025
0498fb3
address comment
zhaohuabing Apr 29, 2025
9953a63
fix lint
zhaohuabing Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/gatewayapi/filters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func (t *Translator) ProcessGRPCFilters(parentRef *RouteParentContext,
route RouteContext,
filters []gwapiv1.GRPCRouteFilter,
resources *resource.Resources,
) (*HTTPFiltersContext, error) {
) (*HTTPFiltersContext, status.Error) {
httpFiltersContext := &HTTPFiltersContext{
ParentRef: parentRef,
Route: route,
Expand Down Expand Up @@ -901,11 +901,11 @@ func (t *Translator) processRequestMirrorFilter(
// This sets the status on the HTTPRoute, should the usage be changed so that the status message reflects that the backendRef is from the filter?
filterNs := filterContext.Route.GetNamespace()
serviceNamespace := NamespaceDerefOr(mirrorBackend.Namespace, filterNs)
err = t.validateBackendRef(mirrorBackendRef, filterContext.ParentRef, filterContext.Route,
err = t.validateBackendRef(mirrorBackendRef, filterContext.Route,
resources, serviceNamespace, resource.KindHTTPRoute)
if err != nil {
return status.NewRouteStatusError(
fmt.Errorf("failed to validate the RequestMirror filter: %w", err), err.Reason())
fmt.Errorf("failed to validate the RequestMirror filter: %w", err), err.Reason()).WithType(gwapiv1.RouteConditionResolvedRefs)
}

destName := fmt.Sprintf("%s-mirror-%d", irRouteDestinationName(filterContext.Route, filterContext.RuleIdx), filterIdx)
Expand Down
Loading
Loading