Skip to content

chore: bump k8s.io to v0.34#7128

Merged
cnvergence merged 4 commits intoenvoyproxy:mainfrom
zirain:bump-k8s.io
Oct 5, 2025
Merged

chore: bump k8s.io to v0.34#7128
cnvergence merged 4 commits intoenvoyproxy:mainfrom
zirain:bump-k8s.io

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Oct 4, 2025

split from #7090

@zirain zirain requested a review from a team as a code owner October 4, 2025 02:38
@@ -2,7 +2,6 @@ backendTLSPolicies:
- apiVersion: gateway.networking.k8s.io/v1alpha3
kind: BackendTLSPolicy
metadata:
creationTimestamp: null
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this's the main change.

arkodg
arkodg previously approved these changes Oct 4, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.09%. Comparing base (7375ef0) to head (cbfd3dd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7128   +/-   ##
=======================================
  Coverage   71.09%   71.09%           
=======================================
  Files         227      228    +1     
  Lines       40582    40589    +7     
=======================================
+ Hits        28851    28858    +7     
- Misses      10041    10042    +1     
+ Partials     1690     1689    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zirain added 4 commits October 4, 2025 20:29
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@cnvergence cnvergence merged commit 2835e6f into envoyproxy:main Oct 5, 2025
53 of 55 checks passed
@zirain zirain deleted the bump-k8s.io branch October 6, 2025 00:56
func CmpResources(t *testing.T, x, y interface{}) {
opts := []cmp.Option{
cmpopts.IgnoreFields(metav1.ObjectMeta{}, "ResourceVersion"),
cmpopts.IgnoreFields(metav1.TypeMeta{}, "Kind", "APIVersion"),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we ignoring Kind ?

Copy link
Copy Markdown
Member Author

@zirain zirain Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be empty, but was   &v1.ConfigMap{
        	            	  	TypeMeta: v1.TypeMeta{
        	            	- 		Kind: "ConfigMap",
        	            	+ 		Kind: "",
        	            	  		... // 1 ignored field
        	            	  	},
        	            	  	ObjectMeta: {Name: "envoy-test-9f86d081", Namespace: "test", Labels: {"app.kubernetes.io/component": "proxy", "app.kubernetes.io/managed-by": "envoy-gateway", "app.kubernetes.io/name": "envoy", "gateway.envoyproxy.io/owning-gateway-name": "test", ...}, OwnerReferences: {{APIVersion: "gateway.networking.k8s.io/v1", Kind: "GatewayClass", Name: "envoy-gateway-class", UID: "foo.bar", ...}}, ...},
        	            	  	Immutable:  nil,
        	            	  	... // 2 identical fields
        	            	  }

looks like there's a change in clinet-go/controller-runtime, it returns empty TypeMeta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants