chore: bump k8s.io to v0.34#7128
Merged
cnvergence merged 4 commits intoenvoyproxy:mainfrom Oct 5, 2025
Merged
Conversation
zirain
commented
Oct 4, 2025
| @@ -2,7 +2,6 @@ backendTLSPolicies: | |||
| - apiVersion: gateway.networking.k8s.io/v1alpha3 | |||
| kind: BackendTLSPolicy | |||
| metadata: | |||
| creationTimestamp: null | |||
arkodg
previously approved these changes
Oct 4, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7128 +/- ##
=======================================
Coverage 71.09% 71.09%
=======================================
Files 227 228 +1
Lines 40582 40589 +7
=======================================
+ Hits 28851 28858 +7
- Misses 10041 10042 +1
+ Partials 1690 1689 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jukie
approved these changes
Oct 5, 2025
cnvergence
approved these changes
Oct 5, 2025
arkodg
reviewed
Oct 7, 2025
| func CmpResources(t *testing.T, x, y interface{}) { | ||
| opts := []cmp.Option{ | ||
| cmpopts.IgnoreFields(metav1.ObjectMeta{}, "ResourceVersion"), | ||
| cmpopts.IgnoreFields(metav1.TypeMeta{}, "Kind", "APIVersion"), |
Member
Author
There was a problem hiding this comment.
Should be empty, but was &v1.ConfigMap{
TypeMeta: v1.TypeMeta{
- Kind: "ConfigMap",
+ Kind: "",
... // 1 ignored field
},
ObjectMeta: {Name: "envoy-test-9f86d081", Namespace: "test", Labels: {"app.kubernetes.io/component": "proxy", "app.kubernetes.io/managed-by": "envoy-gateway", "app.kubernetes.io/name": "envoy", "gateway.envoyproxy.io/owning-gateway-name": "test", ...}, OwnerReferences: {{APIVersion: "gateway.networking.k8s.io/v1", Kind: "GatewayClass", Name: "envoy-gateway-class", UID: "foo.bar", ...}}, ...},
Immutable: nil,
... // 2 identical fields
}
looks like there's a change in clinet-go/controller-runtime, it returns empty TypeMeta.
This was referenced Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split from #7090