Skip to content

chore: remove redundant otelgrpc replace directive#7165

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
shahar-h:remove-replace
Oct 8, 2025
Merged

chore: remove redundant otelgrpc replace directive#7165
arkodg merged 1 commit intoenvoyproxy:mainfrom
shahar-h:remove-replace

Conversation

@shahar-h
Copy link
Copy Markdown
Contributor

@shahar-h shahar-h commented Oct 8, 2025

What this PR does / why we need it:
Remove go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc replace directive since it is not needed anymore after k8s.io/apiserver update to v0.34.1 as part of #7128.

Which issue(s) this PR fixes:
Fixes #

Release Notes: No

Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner October 8, 2025 09:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.09%. Comparing base (30154bb) to head (4d2de73).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7165      +/-   ##
==========================================
- Coverage   71.12%   71.09%   -0.04%     
==========================================
  Files         228      228              
  Lines       40621    40621              
==========================================
- Hits        28891    28878      -13     
- Misses      10043    10053      +10     
- Partials     1687     1690       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shahar-h
Copy link
Copy Markdown
Contributor Author

shahar-h commented Oct 8, 2025

/retest

@arkodg arkodg merged commit 4093d0c into envoyproxy:main Oct 8, 2025
53 of 55 checks passed
@shahar-h shahar-h deleted the remove-replace branch October 9, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants