fix ListenerSetHostnameConflict/ListenerSetProtocolConflict conformance test by zirain · Pull Request #8361 · envoyproxy/gateway

zirain · 2026-02-27T08:13:19Z

Fix ListenerSetHostnameConflict conformance test

fix IncreaseAttachedListenerSets only increase when ListenerSet is valid

netlify · 2026-02-27T08:13:29Z

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name	Link
🔨 Latest commit	`c82d97e`
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69eaa48aa8d9ac0008be4405
😎 Deploy Preview	https://deploy-preview-8361--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

codecov · 2026-02-27T09:28:05Z

Codecov Report

❌ Patch coverage is 88.50174% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.39%. Comparing base (c3d06fa) to head (68da39b).
⚠️ Report is 40 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/gatewayapi/validate.go	90.00%	13 Missing and 6 partials ⚠️
internal/gatewayapi/listener.go	85.54%	7 Missing and 5 partials ⚠️
internal/gatewayapi/contexts.go	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8361      +/-   ##
==========================================
+ Coverage   74.34%   74.39%   +0.04%     
==========================================
  Files         244      244              
  Lines       38768    38935     +167     
==========================================
+ Hits        28824    28967     +143     
- Misses       7950     7962      +12     
- Partials     1994     2006      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zhaohuabing · 2026-03-04T02:22:04Z

Hi @zirain can we split ListenerSetHostnameConflict/ListenerSetProtocolConflict fixes into two PRs, it will be easier to review.

zirain · 2026-03-05T03:56:19Z

Hi @zirain can we split ListenerSetHostnameConflict/ListenerSetProtocolConflict fixes into two PRs, it will be easier to review.

Splited.

zhaohuabing · 2026-03-06T01:10:27Z

kubernetes-sigs/gateway-api#4618

I don't see any gateway conformance tests checking the conflicted condition but thats probably because validation ensures no conflicts on gateway listeners

Hi @zirain can you confirm if the conformance test could pass without adding the conflicted=false condition to the non-conflicted listener?

zirain · 2026-03-06T01:22:12Z

kubernetes.GatewayListenersMustHaveConditions(t, suite.Client, suite.TimeoutConfig, gwNN, generateAcceptedListenerConditions(), "gateway-listener")

func generateAcceptedListenerConditions() []metav1.Condition {
	return []metav1.Condition{
		{
			Type:   string(gatewayv1.ListenerConditionResolvedRefs),
			Status: metav1.ConditionTrue,
			Reason: "", // any reason
		},
		{
			Type:   string(gatewayv1.ListenerConditionAccepted),
			Status: metav1.ConditionTrue,
			Reason: "", // any reason
		},
		{
			Type:   string(gatewayv1.ListenerConditionProgrammed),
			Status: metav1.ConditionTrue,
			Reason: "", // any reason
		},
		{
			Type:   string(gatewayv1.ListenerConditionConflicted), // this's required.
			Status: metav1.ConditionFalse,
			Reason: "", // any reason
		},
	}
}

zirain · 2026-04-03T06:38:57Z

@jukie @zhaohuabing can you take a review again?

jukie · 2026-04-03T14:27:32Z

+	for _, gateway := range gateways {
+		portListenerInfo := map[gwapiv1.PortNumber]*portListeners{}
+		for _, listener := range gateway.listeners {
+			if listener.Protocol == gwapiv1.UDPProtocolType || listener.Protocol == gwapiv1.TCPProtocolType {


Unsupported listeners should probably be skipped in hostname conflict checks too. Otherwise an invalid-first listener can still win hostname precedence and cause a later valid listener on the same hostname/port to be marked HostnameConflict.

Let's do #8577 first.

Not opposed to it being in a follow-up either

arkodg · 2026-04-06T02:46:03Z

+		if countInt32 > 0 {
+			g.Status.AttachedListenerSets = ptr.To(countInt32)
+		}
+		return


if we return here, arent we avoid an increment ?

if we reach here, that means new count is 0 and AttachedListenerSets is nil, so it's safe to skip.

Signed-off-by: zirain <zirain2009@gmail.com>

jukie · 2026-04-23T15:15:51Z

+	specValid := t.validateAllowedNamespaces(listener)
+	if !validateProtocolRules(listener) {
+		specValid = false
+	}
+
+	// Phase 2: Validate allowed routes based on protocol
+	if listener.Protocol == gwapiv1.HTTPProtocolType ||
+		listener.Protocol == gwapiv1.HTTPSProtocolType ||
+		listener.Protocol == gwapiv1.TCPProtocolType ||
+		listener.Protocol == gwapiv1.UDPProtocolType ||
+		listener.Protocol == gwapiv1.TLSProtocolType {
+		var tlsMode *gwapiv1.TLSModeType
+		if listener.TLS != nil {
+			tlsMode = listener.TLS.Mode
+		}
+		allowedKinds := allowedRouteKindsForProtocol(listener.Protocol, tlsMode)
+		if !t.validateAllowedRoutes(listener, allowedKinds...) {
+			specValid = false
+		}
+	} else {


Can this be reworked or simplified? The else block effectively covers the !validateProtocolRules case if I'm reading correctly.

that's why I want merge #8577 first, will make this one cleaner.

Co-authored-by: Isaac Wilson <isaac.wilson514@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com>

jukie · 2026-04-25T02:24:11Z

Can you add a release note too

zirain · 2026-05-06T03:05:42Z

replaced by #8910

zirain requested a review from a team as a code owner February 27, 2026 08:13

zhaohuabing reviewed Feb 27, 2026

View reviewed changes

Comment thread internal/cmd/egctl/testdata/translate/out/backend-endpoint.all.yaml Outdated

zirain changed the title ~~fix ListenerSetHostnameConflict conformance test~~ fix ListenerSetHostnameConflict/ListenerSetProtocolConflict conformance test Feb 27, 2026

zirain force-pushed the listenerset-hostname branch 5 times, most recently from 1663b4e to 668e7f7 Compare March 2, 2026 14:44

zirain commented Mar 2, 2026

View reviewed changes

Comment thread internal/gatewayapi/listener.go Outdated

zirain added this to the v1.8.0-rc.1 Release milestone Mar 2, 2026

zhaohuabing reviewed Mar 4, 2026

View reviewed changes

Comment thread internal/gatewayapi/contexts.go Outdated

zirain force-pushed the listenerset-hostname branch from 9ee8b95 to c861521 Compare March 4, 2026 02:44

zirain changed the title ~~fix ListenerSetHostnameConflict/ListenerSetProtocolConflict conformance test~~ fix ListenerSetHostnameConflict conformance test Mar 4, 2026

zirain force-pushed the listenerset-hostname branch from c861521 to a6d8112 Compare March 4, 2026 02:49

zirain mentioned this pull request Mar 5, 2026

fix ListenerSetProtocolConflict conformace test #8412

Closed

zirain force-pushed the listenerset-hostname branch from 5ae7a19 to d1c0767 Compare March 5, 2026 03:56

zirain force-pushed the listenerset-hostname branch from d1c0767 to 8d5a5d9 Compare March 5, 2026 04:36

zirain force-pushed the listenerset-hostname branch 2 times, most recently from bfd2b62 to 36fa1bc Compare March 9, 2026 08:09

zhaohuabing requested changes Mar 9, 2026

View reviewed changes

Comment thread internal/gatewayapi/validate.go Outdated

zirain force-pushed the listenerset-hostname branch 2 times, most recently from 43de278 to 513cee2 Compare March 16, 2026 08:24

zirain mentioned this pull request Mar 16, 2026

bump Gateway API to v1.5.1 #8533

Merged

zirain force-pushed the listenerset-hostname branch from 513cee2 to 3795153 Compare March 17, 2026 01:18

zirain force-pushed the listenerset-hostname branch from 3349e94 to 19c01ac Compare March 26, 2026 11:56

zirain requested review from jukie and zhaohuabing April 2, 2026 22:53

zirain force-pushed the listenerset-hostname branch 2 times, most recently from 6fc7803 to 7bc5d9c Compare April 3, 2026 06:10

jukie reviewed Apr 3, 2026

View reviewed changes

jukie previously approved these changes Apr 4, 2026

View reviewed changes

zirain requested a review from a team April 4, 2026 03:12

arkodg reviewed Apr 6, 2026

View reviewed changes

zirain dismissed jukie’s stale review via 59f59cb April 6, 2026 11:47

zirain force-pushed the listenerset-hostname branch 2 times, most recently from 59f59cb to 58a2796 Compare April 6, 2026 11:51

zirain marked this pull request as draft April 6, 2026 11:52

zirain force-pushed the listenerset-hostname branch 4 times, most recently from e37f5c2 to 9b7180d Compare April 6, 2026 13:38

zirain added 2 commits April 7, 2026 17:43

skip invalid listener

12b4aa1

Signed-off-by: zirain <zirain2009@gmail.com>

fix ListenerSetHostnameConflict conformance test

68da39b

Signed-off-by: zirain <zirain2009@gmail.com>

zirain force-pushed the listenerset-hostname branch from 9b7180d to 68da39b Compare April 7, 2026 09:43

jukie reviewed Apr 23, 2026

View reviewed changes

Comment thread internal/gatewayapi/contexts.go Outdated

jukie reviewed Apr 23, 2026

View reviewed changes

Update internal/gatewayapi/contexts.go

c82d97e

Co-authored-by: Isaac Wilson <isaac.wilson514@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com>

arkodg modified the milestones: v1.8.0-rc.1 Release, v1.8.0 Release Apr 30, 2026

zirain mentioned this pull request May 4, 2026

fix ListenerSet conformance test #8910

Open

zirain closed this May 6, 2026

Conversation

zirain commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Uh oh!

codecov Bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zhaohuabing commented Mar 4, 2026

Uh oh!

zirain commented Mar 5, 2026

Uh oh!

zhaohuabing commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zirain commented Mar 6, 2026

Uh oh!

Uh oh!

zirain commented Apr 3, 2026

Uh oh!

jukie Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

zirain Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

jukie Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

arkodg Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

zirain Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jukie Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

zirain Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

jukie commented Apr 25, 2026

Uh oh!

zirain commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zirain commented Feb 27, 2026 •

edited

Loading

netlify Bot commented Feb 27, 2026 •

edited

Loading

codecov Bot commented Feb 27, 2026 •

edited

Loading

zhaohuabing commented Mar 6, 2026 •

edited

Loading