Skip to content

fix ListenerSet conformance test#8910

Open
zirain wants to merge 4 commits into
envoyproxy:mainfrom
zirain:rebase-8361
Open

fix ListenerSet conformance test#8910
zirain wants to merge 4 commits into
envoyproxy:mainfrom
zirain:rebase-8361

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented May 4, 2026

Replace #8361

@zirain zirain requested a review from a team as a code owner May 4, 2026 11:25
@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 3c5e532
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69fed5c1e68b860008b59582
😎 Deploy Preview https://deploy-preview-8910--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zirain zirain added this to the v1.8.0 Release milestone May 4, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 202af4ea0e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal/gatewayapi/validate.go Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 83.52490% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.84%. Comparing base (da685e8) to head (3c5e532).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/validate.go 82.60% 31 Missing and 5 partials ⚠️
internal/gatewayapi/listener.go 80.00% 2 Missing and 2 partials ⚠️
internal/gatewayapi/listenerset.go 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8910      +/-   ##
==========================================
+ Coverage   74.73%   74.84%   +0.10%     
==========================================
  Files         251      251              
  Lines       40394    40565     +171     
==========================================
+ Hits        30189    30359     +170     
+ Misses       8138     8129       -9     
- Partials     2067     2077      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain
Copy link
Copy Markdown
Member Author

zirain commented May 4, 2026

@codex

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fdfcdd87e6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal/gatewayapi/validate.go Outdated
zirain added 3 commits May 9, 2026 12:34
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant