fix: HealthCheck should respect endpoint hostname by zirain · Pull Request #8854 · envoyproxy/gateway

zirain · 2026-04-25T00:13:34Z

netlify · 2026-04-25T00:13:40Z

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name	Link
🔨 Latest commit	`4644cd8`
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69fad47fe8f97c0008f463df
😎 Deploy Preview	https://deploy-preview-8854--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

codecov · 2026-04-25T00:23:36Z

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.72%. Comparing base (69b1dde) to head (4644cd8).

Files with missing lines	Patch %	Lines
internal/xds/translator/cluster.go	92.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8854      +/-   ##
==========================================
- Coverage   74.73%   74.72%   -0.02%     
==========================================
  Files         251      251              
  Lines       40360    40379      +19     
==========================================
+ Hits        30165    30175      +10     
- Misses       8130     8135       +5     
- Partials     2065     2069       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain

…ostFrom test - Remove auto-derive of DestinationEndpoint.Hostname from FQDN in route.go (changed IR output for all FQDN backends unnecessarily) - Include health check testdata from envoyproxy#8854 (by @zirain) - Add backendtrafficpolicy-with-healthcheck-auto-host-rewrite test exercising HostFrom=Endpoint with hostname.type: Backend Signed-off-by: asalvador <asalvador@newrelic.com>

Signed-off-by: asalvador <asalvador@newrelic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2d4d6a8a3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

albsga4

Nice approach — passing the URLRewrite directly to the xDS translator is cleaner than adding a new IR field. Tested locally with a gatewayapi golden test for hostname.type: Backend (auto-host-rewrite via HTTPRouteFilter ExtensionRef) and it works correctly on your branch.

The unit test in cluster_test.go covers the xDS level well. One suggestion: a gatewayapi integration test would also cover the full flow (HTTPRouteFilter → IR → xDS). Feel free to grab the test input from my PR: backendtrafficpolicy-with-healthcheck-auto-host-rewrite.in.yaml

It has two routes:

Auto-host-rewrite + no explicit http.hostname → health check uses Backend.endpoint.hostname
Auto-host-rewrite + explicit http.hostname → explicit value wins

I'll close #8851 in favor of this PR. Thanks for taking this on!

zirain · 2026-04-25T22:45:44Z

@copilot resolve the merge conflicts in this pull request

arkodg · 2026-04-26T02:29:47Z

imo irrespective of URL rewrite being enabled or not, the endpoint hostname should be used if healthCheck host is unset

zirain · 2026-04-26T12:48:41Z

imo irrespective of URL rewrite being enabled or not, the endpoint hostname should be used if healthCheck host is unset

I do believe we should use Endpoint hostname by default if we don't care aboud backward compatibility.

albsga4

Tested hostname.type: Backend with two FQDN backends without the explicit hostname field on the Backend endpoint. Routing works (Envoy uses the FQDN address for STRICT_DNS auto_host_rewrite), but health checks get nothing because ep.Hostname is nil.

Suggested a fallback to ep.Host (the FQDN address) so users don't need to duplicate the FQDN.

albsga4

Requesting changes: hostname.type: Backend with FQDN backends that don't set the explicit hostname field results in no per-endpoint health check hostname. See suggestion for fallback to ep.Host.

albsga4

The hostname field on BackendEndpoint was added in #6503 / #6280 specifically for IP-based backends where there is no DNS name for auto_host_rewrite to use. For FQDN backends, the FQDN address IS the hostname — forcing users to duplicate it doesn't add value.

Verified on a live cluster: auto_host_rewrite on STRICT_DNS correctly rewrites Host to the FQDN address for each endpoint, even without the explicit hostname field. But health checks get nothing because ep.Hostname is nil.

arkodg · 2026-04-30T13:53:38Z

 					Hostname:          ptr.Deref(irEp.Hostname, ""),
 					Address:           buildAddress(irEp),
-					HealthCheckConfig: buildHealthCheckConfig(hc, irEp),
+					HealthCheckConfig: buildHealthCheckConfig(hc, rewrite, irEp),


imo we shouldnt be using route rewrite info which is for user requests for health check request semantics

Correct me if I'm wrong, when you rewrited the URL that mostly because the upstream may only accept the rewrited host(no matter it's from per-route or per-backend).

Rewriting applies to user requests initiated by downstream
Health check requests are initiated by envoy with specific info of backend ( host, dns/ip)

Removed it now, we could add it back if needed in the future.

arkodg · 2026-05-03T23:17:59Z

+    - matches:
+      - path:
+          value: "/v6-rewrite"
+      # Hostname rewrite filter applied, should use example2.com when doing health check.


can the title & examples be updated to not rely on URLRewrite for heathcheck semantics

Signed-off-by: zirain <zirain2009@gmail.com>

Co-authored-by: albsga4 <asalvador@newrelic.com> Signed-off-by: zirain <zirain2009@gmail.com>

Signed-off-by: zirain <zirain2009@gmail.com>

zirain mentioned this pull request Apr 25, 2026

fix: use per-endpoint hostname for health checks with auto-host-rewrite #8851

Closed

zirain force-pushed the host-rewrite-healthcheck branch 2 times, most recently from f31f65c to f2d4d6a Compare April 25, 2026 00:43

albsga4 added a commit to albsga4/gateway that referenced this pull request Apr 25, 2026

fix: update testdata from latest envoyproxy#8854 (fixes yamllint)

f4aafad

Signed-off-by: asalvador <asalvador@newrelic.com>

zirain marked this pull request as ready for review April 25, 2026 09:17

zirain requested a review from a team as a code owner April 25, 2026 09:17

chatgpt-codex-connector Bot reviewed Apr 25, 2026

View reviewed changes

Comment thread internal/gatewayapi/testdata/backendtrafficpolicy-with-healthcheck.out.yaml Outdated

Comment thread internal/xds/translator/testdata/out/xds-ir/health-check.clusters.yaml

zirain changed the title ~~chore: update health check testdata~~ fix: HealthCheck should respect URLWrite host configuration. Apr 25, 2026

albsga4 approved these changes Apr 25, 2026

View reviewed changes

albsga4 mentioned this pull request Apr 25, 2026

Health check Host header should use backend endpoint FQDN when auto-host-rewrite is configured #8848

Open

arkodg added this to the v1.8.0-rc.1 Release milestone Apr 26, 2026

arkodg added the cherrypick/release-v1.7.3 label Apr 26, 2026

albsga4 reviewed Apr 27, 2026

View reviewed changes

Comment thread internal/xds/translator/cluster.go

albsga4 suggested changes Apr 27, 2026

View reviewed changes

zirain force-pushed the host-rewrite-healthcheck branch from b90975e to 9f2c250 Compare April 28, 2026 02:46

zirain requested a review from albsga4 April 28, 2026 06:23

cnvergence mentioned this pull request Apr 28, 2026

[release/v1.7] Cherry-pick for v1.7.3 #8869

Merged

albsga4 suggested changes Apr 28, 2026

View reviewed changes

Comment thread internal/xds/translator/cluster.go

arkodg modified the milestones: v1.8.0-rc.1 Release, v1.8.0 Release Apr 30, 2026

arkodg reviewed Apr 30, 2026

View reviewed changes

zirain force-pushed the host-rewrite-healthcheck branch from 06d6519 to dbf8f63 Compare May 1, 2026 13:54

zirain requested review from albsga4 and arkodg May 3, 2026 15:24

arkodg reviewed May 3, 2026

View reviewed changes

zhaohuabing reviewed May 6, 2026

View reviewed changes

Comment thread internal/xds/translator/cluster.go

zhaohuabing requested review from arkodg and zhaohuabing May 6, 2026 03:42

zirain changed the title ~~fix: HealthCheck should respect URLWrite host configuration.~~ fix: HealthCheck should respect URLWrite host configuration in backend refs May 6, 2026

zirain changed the title ~~fix: HealthCheck should respect URLWrite host configuration in backend refs~~ fix: HealthCheck should respect auto-host-rewrite May 6, 2026

zirain and others added 9 commits May 6, 2026 11:47

chore: update health check testdata

22df29c

Signed-off-by: zirain <zirain2009@gmail.com>

fix: HealthCheck should respect host from URLRewrite

d0f4787

Signed-off-by: zirain <zirain2009@gmail.com>

Set health-check host to rewritten route hostname

8ed9fae

Signed-off-by: zirain <zirain2009@gmail.com>

Update internal/xds/translator/cluster.go

5ea16e3

Co-authored-by: albsga4 <asalvador@newrelic.com> Signed-off-by: zirain <zirain2009@gmail.com>

fix

f8767eb

Signed-off-by: zirain <zirain2009@gmail.com>

fix test

b8996da

Signed-off-by: zirain <zirain2009@gmail.com>

don't respect URLWrite from route

d23caa8

Signed-off-by: zirain <zirain2009@gmail.com>

fix gen

505d9b6

Signed-off-by: zirain <zirain2009@gmail.com>

update gen

48ff586

Signed-off-by: zirain <zirain2009@gmail.com>

zirain force-pushed the host-rewrite-healthcheck branch from aa81ed1 to 48ff586 Compare May 6, 2026 03:56

zirain changed the title ~~fix: HealthCheck should respect auto-host-rewrite~~ fix: HealthCheck should respect endpoint hostname May 6, 2026

update comment

4644cd8

Signed-off-by: zirain <zirain2009@gmail.com>

cnvergence approved these changes May 6, 2026

View reviewed changes

zirain removed the cherrypick/release-v1.7.3 label May 7, 2026

zirain removed this from the v1.8.0 Release milestone May 7, 2026

zirain marked this pull request as draft May 7, 2026 12:56

Conversation

zirain commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Uh oh!

codecov Bot commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

albsga4 left a comment

Choose a reason for hiding this comment

Uh oh!

zirain commented Apr 25, 2026

Uh oh!

arkodg commented Apr 26, 2026

Uh oh!

zirain commented Apr 26, 2026

Uh oh!

albsga4 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

albsga4 left a comment

Choose a reason for hiding this comment

Uh oh!

albsga4 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arkodg Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

zirain May 1, 2026

Choose a reason for hiding this comment

Uh oh!

arkodg May 3, 2026

Choose a reason for hiding this comment

Uh oh!

zirain May 3, 2026

Choose a reason for hiding this comment

Uh oh!

arkodg May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zirain commented Apr 25, 2026 •

edited

Loading

netlify Bot commented Apr 25, 2026 •

edited

Loading

codecov Bot commented Apr 25, 2026 •

edited

Loading

arkodg May 3, 2026 •

edited

Loading