Skip to content

[release/v1.7] Cherry-pick for v1.7.3#8869

Merged
cnvergence merged 10 commits intoenvoyproxy:release/v1.7from
cnvergence:cherry-pick-v.1.7.3
May 9, 2026
Merged

[release/v1.7] Cherry-pick for v1.7.3#8869
cnvergence merged 10 commits intoenvoyproxy:release/v1.7from
cnvergence:cherry-pick-v.1.7.3

Conversation

@cnvergence
Copy link
Copy Markdown
Member

What type of PR is this?

https://github.com/envoyproxy/gateway/pulls?q=is%3Apr+author%3Arudrakhp+is%3Aclosed+label%3Acherrypick%2Frelease-v1.7.3

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

zhaohuabing and others added 5 commits April 27, 2026 17:26
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 4768ca7)
)

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
(cherry picked from commit 3f70a89)
…voyproxy#8699)

* force HTTP1 for upstream connections for WS and WSS backends

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* use different clusters for mixed upstream protocols

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* update

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix lint

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 7633125)
* fix: reason with multiple errors rejected validation

Signed-off-by: zirain <zirain2009@gmail.com>

* release notes

Signed-off-by: zirain <zirain2009@gmail.com>

* fix lint

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 7811d86)
…yproxy#8785)

* feat: Allow configuring envoy proxy defaults via helm chart

This commit is a continuation of the previous work to support supplying default proxy settings added in envoyproxy#7698 and adds three new chart values under `global.images.envoyProxy`:

| Value | Type | Default | Description |
|----------------------------------------|--------|------|---------------------------------------------------------------------|
| `global.images.envoyProxy.image`       | string | `""` | Full image name (`registry/repo:tag`) for the Envoy Proxy container |
| `global.images.envoyProxy.pullPolicy`  | string | `""` | Image pull policy                                                   |
| `global.images.envoyProxy.pullSecrets` | list   | `[]` | Image pull secrets                                                  |

When any of these are set, the chart generates an `envoyProxy:` block inside the `EnvoyGateway` ConfigMap, wiring into the existing `EnvoyGatewaySpec.envoyProxy` field (added in envoyproxy#7698). The global `imageRegistry` override takes highest precedence, consistent with other chart components.

Full EnvoyProxy defaults (replicas, resources, etc.) can be provided via `config.envoyGateway.envoyProxy`; the image values are merged on top.

Closes envoyproxy#4764.

Signed-off-by: Michael Sommerville <msommerville@gmail.com>
(cherry picked from commit 8570285)
@cnvergence cnvergence requested a review from a team as a code owner April 27, 2026 17:43
@cnvergence cnvergence changed the title Cherry pick v.1.7.3 [release/v1.7] Cherry-pick for v1.7.3 Apr 27, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 092cc67e6b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +187 to +190
{{- if .Values.global.images.envoyProxy.image }}
{{- $container := dict "image" (include "eg.envoyProxy.image" .) }}
{{- if .Values.global.images.envoyProxy.pullPolicy }}
{{- $_ := set $container "imagePullPolicy" .Values.global.images.envoyProxy.pullPolicy }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Honor envoyProxy pull policy without image override

The Envoy Proxy override block is nested under if .Values.global.images.envoyProxy.image, which means setting only global.images.envoyProxy.pullPolicy (and similarly pull secrets) produces no envoyProxy.provider.kubernetes.envoyDeployment patch. In practice, these documented values are silently ignored unless users also set an image, so chart users cannot change pull behavior independently.

Useful? React with 👍 / 👎.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 98.04878% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.91%. Comparing base (4d41cab) to head (6bf15d1).

Files with missing lines Patch % Lines
internal/gatewayapi/extensionserverpolicy.go 87.50% 1 Missing and 1 partial ⚠️
internal/ir/xds.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.7    #8869      +/-   ##
================================================
+ Coverage         73.83%   73.91%   +0.07%     
================================================
  Files               241      241              
  Lines             36803    36939     +136     
================================================
+ Hits              27175    27304     +129     
- Misses             7723     7728       +5     
- Partials           1905     1907       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rudrakhp
rudrakhp previously approved these changes Apr 27, 2026
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
zhaohuabing
zhaohuabing previously approved these changes Apr 28, 2026
@zhaohuabing
Copy link
Copy Markdown
Member

/retest

@cnvergence
Copy link
Copy Markdown
Member Author

Waiting for #8854

jukie
jukie previously approved these changes Apr 29, 2026
@cnvergence cnvergence dismissed stale reviews from jukie and zhaohuabing via 46d8b75 May 8, 2026 14:46
arkodg and others added 2 commits May 8, 2026 16:48
…8929)

* fix: respect backend endpoint hostname for health checks

- Keep BackendTrafficPolicy HTTP health check hostnames as explicit cluster-level hosts, and leave route-derived host fallback to xDS cluster translation.
- Preserve Backend endpoint hostnames as per-endpoint overrides via Endpoint.HealthCheckConfig.hostname, ahead of the route fallback.
- Update gatewayapi/xDS fixtures, release notes, and generated API docs/CRDs for the host selection order.

- go test ./internal/ir
- go test ./internal/xds/translator
- go test ./internal/gatewayapi -run TestTranslate/backendtrafficpolicy
- go test ./internal/gatewayapi -run TestTranslate/(clienttrafficpolicy-http-health-check|envoyextensionpolicy-with-extproc-with-retries|envoyextensionpolicy-with-extproc-with-traffic-features|envoyproxy-accesslog-with-traffic|envoyproxy-tracing-backend-uds|envoyproxy-tracing-backend|securitypolicy-with-jwt-backendcluster|securitypolicy-with-jwt-backendsettings)
- make generate
- make manifests
- git diff --check

Signed-off-by: Arko Dasgupta <arkodg@gmail.com>
Co-authored-by: Codex <noreply@openai.com>

* fix gen

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: Arko Dasgupta <arkodg@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence force-pushed the cherry-pick-v.1.7.3 branch from 46d8b75 to f6f04d3 Compare May 8, 2026 14:48
@cnvergence
Copy link
Copy Markdown
Member Author

We have decided to cherry-pick this PR as well #8929

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence
Copy link
Copy Markdown
Member Author

/retest

arkodg
arkodg previously approved these changes May 8, 2026
@arko-oai
Copy link
Copy Markdown

arko-oai commented May 8, 2026

why is 092cc67 in this commit

…rt (envoyproxy#8785)"

This reverts commit 092cc67.

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence
Copy link
Copy Markdown
Member Author

We have misunderstood and claimed it is a fix to the helm chart, not a new addition.
I have reverted this commit 😉

@cnvergence cnvergence merged commit 1aa5008 into envoyproxy:release/v1.7 May 9, 2026
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants