Conversation
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 22 22
Lines 1354 1354
=======================================
Hits 1235 1235
Misses 119 119
Continue to review full report at Codecov.
|
Bisaloo
left a comment
There was a problem hiding this comment.
Thanks! This fixed my use case. Shouldn't quantiles get the same treatment though (even though it's less likely to already have a column named quantiles in a sample based format)?
|
yes, good point |
Bisaloo
left a comment
There was a problem hiding this comment.
Looks good! We just need to add regression tests for this. I can do it if you'd like.
|
That would be great, thanks. |
|
I'll let Nikos write the |
Fixes #222