Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 22 22
Lines 1355 1355
=======================================
Hits 1236 1236
Misses 119 119
Continue to review full report at Codecov.
|
Collaborator
|
Very confusing... Thanks for looking into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When by is not null we saw an issue with
add_coveragehighlighted in #223. This appears to be caused by an issue in thedata.tablecode. Dropping into debug changing the call to themeanfunction to be explict (i.ebase::mean) fixes the issue on my system. If this also causes no reversions on CI etc I'd suggest merging as aa bug fix for bleeding edge users. I can't identify any changes indata.tablethat would lead to this change so still hypothetical that this was the system level difference.